Skip to content

Conversation

@feifei325
Copy link
Contributor

@feifei325 feifei325 commented Jun 16, 2025

Related GitHub Issue

Closes: #4100

Description

This PR fixes the ambiguity between subtask and overall task completion in the Boomerang socket event handling logic.
Specifically, it introduces a flag (isSubtask) in the task completion event payload to clearly indicate whether the event refers to a subtask or the overall task. This prevents misinterpretation on the client side and improves task tracking accuracy.

Test Procedure

Type of Change

  • 🐛 Bug Fix: Non-breaking change that fixes an issue.
  • New Feature: Non-breaking change that adds functionality.
  • 💥 Breaking Change: Fix or feature that would cause existing functionality to not work as expected.
  • ♻️ Refactor: Code change that neither fixes a bug nor adds a feature.
  • 💅 Style: Changes that do not affect the meaning of the code (white-space, formatting, etc.).
  • 📚 Documentation: Updates to documentation files.
  • ⚙️ Build/CI: Changes to the build process or CI configuration.
  • 🧹 Chore: Other changes that don't modify src or test files.

Screenshots / Videos

  • subTask Complete

image

  • rootTask Complete
image

Documentation Updates

Additional Notes

Get in Touch


Important

Adds isSubtask flag to taskCompleted event payload for distinguishing subtask completion, updating schemas and event handling accordingly.

  • Behavior:
    • Adds isSubtask flag to taskCompleted event payload in api.ts, ipc.ts, and src/extension/api.ts to distinguish between subtask and overall task completion.
    • Sets isSubtask to true if cline.rootTask is defined in src/extension/api.ts.
  • Schemas:
    • Adds isSubtaskSchema in ipc.ts to validate the isSubtask flag.
  • Event Handling:
    • Updates RooCodeAPIEvents and rooCodeEventsSchema in api.ts and ipc.ts to include isSubtask in taskCompleted event.

This description was created by Ellipsis for 461664db99d22a50a5d33b4b610bcc138c3c2428. You can customize this summary. It will automatically update as commits are pushed.

@feifei325 feifei325 requested review from cte, jr and mrubens as code owners June 16, 2025 08:16
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. bug Something isn't working labels Jun 16, 2025
@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jun 16, 2025
@feifei325 feifei325 force-pushed the fix/4100-subtask-completion-mismatch branch from 461664d to b8bb8c4 Compare June 16, 2025 08:31
@daniel-lxs daniel-lxs moved this from Triage to PR [Needs Prelim Review] in Roo Code Roadmap Jun 16, 2025
@hannesrudolph hannesrudolph added PR - Needs Preliminary Review and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Jun 16, 2025
Copy link
Member

@daniel-lxs daniel-lxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, export const isSubtaskSchema = z.object({ can later be renamed if we want to include more information about the subtask.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 17, 2025
@daniel-lxs daniel-lxs moved this from PR [Needs Prelim Review] to PR [Needs Review] in Roo Code Roadmap Jun 17, 2025
@mrubens mrubens merged commit 5c5ee8c into RooCodeInc:main Jun 17, 2025
19 checks passed
@github-project-automation github-project-automation bot moved this from PR [Needs Review] to Done in Roo Code Roadmap Jun 17, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jun 17, 2025
valekseev pushed a commit to valekseev/Roo-Code that referenced this pull request Jun 18, 2025
cte pushed a commit that referenced this pull request Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer PR - Needs Review size:S This PR changes 10-29 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Unable to Distinguish Between Subtask Completion and Overall Task Completion in Socket-Based Boomerang Task

4 participants