-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Fix/4100 subtask completion mismatch #4738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mrubens
merged 3 commits into
RooCodeInc:main
from
feifei325:fix/4100-subtask-completion-mismatch
Jun 17, 2025
Merged
Fix/4100 subtask completion mismatch #4738
mrubens
merged 3 commits into
RooCodeInc:main
from
feifei325:fix/4100-subtask-completion-mismatch
Jun 17, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yansheng3 <[email protected]>
461664d to
b8bb8c4
Compare
daniel-lxs
approved these changes
Jun 17, 2025
Member
daniel-lxs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, export const isSubtaskSchema = z.object({ can later be renamed if we want to include more information about the subtask.
mrubens
approved these changes
Jun 17, 2025
valekseev
pushed a commit
to valekseev/Roo-Code
that referenced
this pull request
Jun 18, 2025
Co-authored-by: yansheng3 <[email protected]>
cte
pushed a commit
that referenced
this pull request
Jun 24, 2025
Co-authored-by: yansheng3 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
lgtm
This PR has been approved by a maintainer
PR - Needs Review
size:S
This PR changes 10-29 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related GitHub Issue
Closes: #4100
Description
This PR fixes the ambiguity between subtask and overall task completion in the Boomerang socket event handling logic.
Specifically, it introduces a flag (isSubtask) in the task completion event payload to clearly indicate whether the event refers to a subtask or the overall task. This prevents misinterpretation on the client side and improves task tracking accuracy.
Test Procedure
Type of Change
srcor test files.Screenshots / Videos
Documentation Updates
Additional Notes
Get in Touch
Important
Adds
isSubtaskflag totaskCompletedevent payload for distinguishing subtask completion, updating schemas and event handling accordingly.isSubtaskflag totaskCompletedevent payload inapi.ts,ipc.ts, andsrc/extension/api.tsto distinguish between subtask and overall task completion.isSubtasktotrueifcline.rootTaskis defined insrc/extension/api.ts.isSubtaskSchemainipc.tsto validate theisSubtaskflag.RooCodeAPIEventsandrooCodeEventsSchemainapi.tsandipc.tsto includeisSubtaskintaskCompletedevent.This description was created by
for 461664db99d22a50a5d33b4b610bcc138c3c2428. You can customize this summary. It will automatically update as commits are pushed.