fix: normalize Windows paths in MCP variable injection (#4739) #4741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:L
mrubens
reviewed
Jun 16, 2025
Collaborator
mrubens
left a comment
mrubens
left a comment
There was a problem hiding this comment.
Think we can use the existing toPosix for this?
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
Member
Author
|
@mrubens |
- Use path.posix.normalize to convert backslashes to forward slashes
- Only normalize strings that contain path separators
- Ensures cross-platform compatibility and prevents JSON parsing errors
- Add comprehensive tests for Windows path normalization
- Add tests to verify non-path variables remain unchanged
- Fixes issue where ${workspaceFolder} with Windows paths caused invalid JSON
daniel-lxs
force-pushed
the
fix/issue-4739-vscode-magic-variables-mcp
branch
from
3f2ede6 to
4cbe740
Compare
mrubens
approved these changes
Jun 17, 2025
github-project-automation
bot
moved this from PR [Needs Review]
to Done
in Roo Code Roadmap
valekseev
pushed a commit
to valekseev/Roo-Code
that referenced
this pull request
Jun 18, 2025
cte
pushed a commit
that referenced
this pull request
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4739
This PR resolves the issue where VS Code magic variables like
${workspaceFolder}don't work in MCP configuration on Windows due to backslashes in paths causing invalid JSON.Changes Made
injectVariablesfunction insrc/utils/config.tsto normalize Windows pathspath.posix.normalizeto convert backslashes to forward slashes\or/)Testing
${workspaceFolder}now work correctlyVerification of Acceptance Criteria
${workspaceFolder}with Windows paths no longer causes "Invalid MCP settings JSON format" errorTechnical Details
Root Cause: The original
injectVariablesfunction performed direct string replacement without considering that Windows paths contain backslashes, which are escape characters in JSON.Solution:
\or/)path.posix.normalizeto use forward slashes consistentlyWhy forward slashes: Windows supports forward slashes in paths, and they work consistently across all platforms without JSON escaping issues.
Checklist
Important
Normalize Windows paths in
injectVariablesto use forward slashes, fixing JSON issues in MCP configuration.injectVariablesinconfig.tsnow normalizes Windows paths to use forward slashes.config.spec.ts.This description was created by
for 3f2ede6. You can customize this summary. It will automatically update as commits are pushed.