feat: add experimental setting to disable diff visualization for all edit tools #4752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new setting `disableDiffVisualization` that allows users to disable the diff view when editing files. When enabled, files will open directly in the editor instead of showing a side-by-side diff view. This helps prevent Language Server Protocol (LSP) crashes that can occur with very large files, particularly affecting C# developers. The changes made by Roo are still visible in the chat window. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
dosubot
bot
added
size:M
hannesrudolph
added
the
Issue/PR - Triage
- Moved disableDiffVisualization from global settings to experimental settings - Updated all references to access it through experiments instead - Fixed test cases to include the new experiment - Updated translations to reflect experimental nature - Setting now properly affects ALL edit tools (write_to_file, apply_diff, insert_content, search_and_replace) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
hannesrudolph
changed the title
hannesrudolph
added
PR - Needs Preliminary Review
and removed
Issue/PR - Triage
Collaborator
Author
|
This automated test is not working. |
github-project-automation
bot
moved this from PR [Needs Prelim Review]
to Done
in Roo Code Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
disableDiffVisualizationthat allows users to disable diff visualization for ALL edit toolswrite_to_fileapply_diffinsert_contentsearch_and_replaceImplementation Details
disableDiffVisualizationas an experimental feature in theexperimentsschemaDiffViewProviderto check the experiment setting and open files directly when disabledDiffViewProvider.open()methodKey Changes
Related Issues
This addresses the concern raised in #4576 (comment) about URI length limitations causing C# LSP crashes.
Closes #1696
Test plan
🤖 Generated with Claude Code
Important
Adds
disableDiffVisualizationsetting to open files directly in editor, preventing LSP crashes with large files, with UI and test updates.disableDiffVisualizationsetting to disable diff view, opening files directly in editor.disableDiffVisualizationto settings schema inexperiment.ts.DiffViewProviderto check setting and open files directly if disabled.ClineProviderto pass setting toTask.settings.json.experiments.test.tsandExtensionStateContext.test.tsx.settings.json.This description was created by
for 530c5c4. You can customize this summary. It will automatically update as commits are pushed.