Skip to content

Conversation

@mrubens
Copy link
Collaborator

@mrubens mrubens commented Jun 17, 2025

To match

:start_line: (required) The line number of original content where the search block starts.

Closes #4744


Important

Make start_line parameter mandatory in diff operations to match legacy behavior.

  • Behavior:
    • Change start_line from optional to required in multi-file-search-replace.ts and multiApplyDiffTool.ts.
    • Affects diff processing and validation, ensuring start_line is always specified.
  • Documentation:
    • Update comments and error messages in multi-file-search-replace.ts to reflect start_line requirement.
    • Modify XML parsing error message in multiApplyDiffTool.ts to indicate start_line is required.

This description was created by Ellipsis for 38dd071. You can customize this summary. It will automatically update as commits are pushed.

Copy link
Member

@daniel-lxs daniel-lxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 17, 2025
@mrubens mrubens merged commit 48c9bd5 into main Jun 17, 2025
22 checks passed
@mrubens mrubens deleted the encourage_use_of_start_line_in_multi_file_diff branch June 17, 2025 14:40
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jun 17, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Search and replace tool needs to fail if search query not specific enough

4 participants