Fixes #4779: Add comprehensive validation and error handling for codebase indexing #4780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…base indexing - Add vector dimension validation in QdrantVectorStore.upsertPoints() to catch mismatched vector sizes before sending to Qdrant - Add enhanced error logging with detailed context including vector dimensions, collection info, and sample data - Improve batch processing error handling in DirectoryScanner with better retry logging and error context - Update tests to use correct 1536-dimensional vectors matching the expected collection configuration - Add validation for point structure (id, vector, payload) before processing - Add checks for invalid vector values (NaN, Infinity) that could cause Bad Request errors This should resolve the 'Error processing batch: Error:Bad Request' issue by catching and providing clear error messages for common causes like dimension mismatches and invalid vector data.
dosubot
bot
added
size:L
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
|
|
||
| await expect(vectorStore.upsertPoints(mockPoints)).rejects.toThrow(upsertError) | ||
| await expect(vectorStore.upsertPoints(mockPoints)).rejects.toThrow( | ||
| "Failed to upsert 1 points to collection ws-a1b2c3d4e5f6g7h8: Upsert failed", |
Contributor
There was a problem hiding this comment.
Typographical note: The error message says "1 points" which seems grammatically incorrect. Consider changing it to "1 point" for singular.
Suggested change
| "Failed to upsert 1 points to collection ws-a1b2c3d4e5f6g7h8: Upsert failed", | |
| "Failed to upsert 1 point to collection ws-a1b2c3d4e5f6g7h8: Upsert failed", |
hannesrudolph
added
the
Issue/PR - Triage
Member
|
Closing, see #4779 (comment) Also this is handled on #4432. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the "Bad Request" error that occurs during codebase indexing by adding comprehensive validation and enhanced error handling.
Changes Made
🔧 Core Fixes
🧪 Test Updates
🛡️ Validation Improvements
Root Cause Analysis
The "Bad Request" error was likely caused by:
Testing
Impact
This fix should resolve the indexing failures reported in issue #4779 by:
Closes #4779
Important
Adds vector dimension validation and enhanced error handling for codebase indexing in
QdrantVectorStoreandDirectoryScanner.QdrantVectorStore.upsertPoints()to catch mismatched vector sizes.QdrantVectorStore.upsertPoints()with detailed context.DirectoryScanner.processBatch()with retry logging.QdrantVectorStore.upsertPoints().QdrantVectorStore.upsertPoints().qdrant-client.spec.tsto use correct 1536-dimensional vectors.This description was created by
for 73b11b1. You can customize this summary. It will automatically update as commits are pushed.