Skip to content

Conversation

@mrubens
Copy link
Collaborator

@mrubens mrubens commented Jun 17, 2025

Hopefully this helps with the LLM not knowing the current directory when executing commands.


Important

getEnvironmentDetails now includes the current working directory for active and inactive terminals, with updated tests to verify this behavior.

  • Behavior:
    • getEnvironmentDetails in getEnvironmentDetails.ts now includes the current working directory for both active and inactive terminals.
    • Active terminals display "### Working Directory" and "### Original command".
    • Inactive terminals display "### Working Directory" and "Command".
  • Tests:
    • Updated getEnvironmentDetails.spec.ts to test inclusion of working directory for active and inactive terminals.
    • Added mock implementations for getCurrentWorkingDirectory in terminal mocks.

This description was created by Ellipsis for 4e76969. You can customize this summary. It will automatically update as commits are pushed.

@mrubens mrubens requested review from cte and jr as code owners June 17, 2025 15:50
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request labels Jun 17, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 17, 2025
@mrubens mrubens merged commit a13fd1c into main Jun 17, 2025
21 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jun 17, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Jun 17, 2025
@cte
Copy link
Collaborator

cte commented Jun 17, 2025

I'm curious if you've noticed a difference between terminal integration on versus off. I usually run with it off these days and it seems like these changes will mostly impact the on case.

@mrubens mrubens deleted the include_cwd_in_terminal_details branch June 17, 2025 15:53
@mrubens
Copy link
Collaborator Author

mrubens commented Jun 17, 2025

I'm curious if you've noticed a difference between terminal integration on versus off. I usually run with it off these days and it seems like these changes will mostly impact the on case.

I've only been running with it on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants