Fixes #4794: Fix marketplace blanking after populating

[roomote]

Closes #4794

• Fixed state management issue in MarketplaceViewStateManager where displayItems was not properly initialized
• Improved handling of marketplace items when no filters are active to ensure all items are displayed
• Enhanced initial state loading logic to prevent infinite loops and ensure proper state updates
• Fixed getState method to fall back to allItems when displayItems is empty

The issue was caused by displayItems being set to an empty array when marketplace items were loaded,
even when no filters were applied. This caused the marketplace to appear blank after loading completed.

---

Important

Fixes marketplace blanking issue by ensuring displayItems are properly initialized and updated in MarketplaceViewStateManager.

• Behavior:
  • Fixes displayItems initialization in MarketplaceViewStateManager to prevent marketplace blanking when no filters are active.
  • Updates getState to ensure displayItems defaults to allItems if undefined.
  • Enhances state change handling in MarketplaceView to prevent infinite loops.
• Tests:
  • Adds tests in MarketplaceViewStateManager.spec.ts to verify displayItems initialization and state change notifications.
  • Tests ensure displayItems is never empty when allItems has content and no filters are active.
  • Verifies that state changes do not cause infinite loops and handle errors gracefully.

^{This description was created by for 5ff1732. You can customize this summary. It will automatically update as commits are pushed.}

[cte]

@roomote Add a test for this.

[daniel-lxs]

This looks like it might be a proper fix, I'll move it so I can polish it up if needed

[daniel-lxs]

I was not able to replicate the issue but this change looks like it's good to have. I tested the marketplace and works correctly.

I ran pnpm check-types and pnpm test and didn't find any issues, I'm unsure what's causing the tests to fail on this PR.

Edit: the test needed to be updated to use vitest.