Skip to content

Conversation

@roomote
Copy link
Collaborator

@roomote roomote commented Jun 18, 2025

Summary

This PR fixes issue #4837 by changing the default value of the 'Enable MCP Server Creation' setting from to .

Changes Made

  • Modified line 166
  • Changed to

Why This Change?

The 'Enable MCP Server Creation' setting was enabled by default, which:

  • Added unnecessary context to the system prompt for most users who don't create MCP servers
  • Increased token count without benefit for the majority of users
  • Added complexity to prompts unnecessarily

Impact

  • Reduced token usage for most users
  • Cleaner, more relevant system prompts by default
  • Users who need MCP server creation can still manually enable the setting
  • No breaking changes - existing functionality remains intact

Testing

  • All linting checks pass ✅
  • All type checks pass ✅
  • Change is backwards compatible

Acceptance Criteria Met

✅ Fresh installation will have 'Enable MCP Server Creation' checkbox unchecked by default
✅ Users can still manually enable the setting when needed
✅ No impact on existing functionality

Fixes #4837


Important

Change default enableMcpServerCreation to false in ExtensionStateContextProvider to reduce token usage and simplify prompts.

  • Behavior:
    • Change default enableMcpServerCreation to false in ExtensionStateContextProvider in ExtensionStateContext.tsx.
    • Reduces token usage and simplifies system prompts for users not creating MCP servers.
  • Impact:
    • Users can manually enable MCP server creation if needed.
    • No breaking changes; existing functionality remains intact.
  • Testing:
    • All linting and type checks pass.
    • Backwards compatible change.

This description was created by Ellipsis for 0387c6b. You can customize this summary. It will automatically update as commits are pushed.

- Changed enableMcpServerCreation default value from true to false
- This reduces token usage and provides cleaner system prompts for most users
- Users can still manually enable the setting if needed
@roomote roomote requested review from cte, jr and mrubens as code owners June 18, 2025 15:24
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Jun 18, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 18, 2025
@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jun 18, 2025
@mrubens mrubens merged commit db4f7f3 into main Jun 18, 2025
24 of 25 checks passed
@mrubens mrubens deleted the fix-4837 branch June 18, 2025 16:08
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Jun 18, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jun 18, 2025
valekseev pushed a commit to valekseev/Roo-Code that referenced this pull request Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Default 'Enable MCP Server Creation' to false

5 participants