Skip to content

Conversation

@jr
Copy link
Collaborator

@jr jr commented Jun 20, 2025

Honestly, startup is enough of a mush that it's hard for me to tell if this makes a meaningful difference, but it feels like it's probably a little better.


Important

Introduces attempting-session state in AuthService to handle session acquisition, updating related services and tests.

  • Behavior:
    • Introduces attempting-session state in AuthService to handle session acquisition attempts.
    • Updates isAuthenticated() and hasOrIsAcquiringActiveSession() in AuthService to include attempting-session.
    • MdmService checks for attempting-session in isCompliant().
  • Events:
    • Adds attempting-session event in AuthService.
    • Updates event listeners in CloudService and SettingsService to handle attempting-session.
  • Tests:
    • Updates AuthService.spec.ts to test attempting-session state transitions and event emissions.
    • Updates MdmService.spec.ts to test compliance with attempting-session.

This description was created by Ellipsis for 4cac695. You can customize this summary. It will automatically update as commits are pushed.

@jr jr requested review from cte and mrubens as code owners June 20, 2025 22:54
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jun 20, 2025
@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jun 20, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 20, 2025
@jr jr merged commit 805fe70 into main Jun 20, 2025
22 checks passed
@jr jr deleted the jr/cloud-compliance-states branch June 20, 2025 23:06
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Jun 20, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants