Skip to content

Conversation

@hannesrudolph
Copy link
Collaborator

@hannesrudolph hannesrudolph commented Jun 25, 2025

Description

Pasted_Image_2025-06-25__5_03 PM image

Fixes #5115

This PR adds a persistent version indicator to the main chat screen that displays the current Roo Code version and opens the release notes modal when clicked.

Changes Made

  • Added a clickable version indicator in the top-right corner of the ChatView component
  • The indicator displays "v{version}" using the Package.version value
  • Clicking the indicator opens the existing Announcement modal (release notes)
  • Added proper aria-label for accessibility: "Version {version} - Click to view release notes"
  • Implemented hover effects with subtle styling (border changes on hover)
  • Added comprehensive unit tests to verify functionality

Testing

  • All existing tests pass
  • Added tests for version indicator rendering
  • Added tests for modal show/hide functionality
  • Added tests for proper styling and accessibility
  • Manual testing completed:
    • Version indicator appears in top-right corner
    • Clicking opens the announcement modal
    • Hover effects work as expected

Verification of Acceptance Criteria

  • Persistent version indicator on the main chat screen (not welcome screen)
  • Displays current version number
  • Clickable to trigger release notes modal
  • Uses existing Announcement component
  • Visually appealing but not distracting

Checklist

  • Code follows project style guidelines
  • Self-review completed
  • Comments added for complex logic (none needed)
  • Documentation updated (translations added)
  • No breaking changes
  • Accessibility checked (aria-label added)

Screenshots/Demo

The version indicator appears in the top-right corner of the chat screen with subtle styling:

  • Text: v{version} in small font
  • Border: Subtle border that highlights on hover
  • Position: Absolute positioning in top-right corner
  • Z-index: Ensures it stays above other content

Important

Adds a persistent version indicator to the chat screen with localization and comprehensive testing.

  • UI Enhancement:
    • Adds a persistent version indicator to ChatView.tsx.
    • Introduces VersionIndicator component in common/VersionIndicator.tsx.
    • Indicator displays current version and opens release notes modal on click.
    • Includes hover effects and accessibility features (aria-label).
  • Testing:
    • Adds unit tests for rendering, modal functionality, styling, and accessibility in ChatView.spec.tsx.
  • Localization:
    • Updates localization files to include version indicator aria-label in multiple languages.

This description was created by Ellipsis for 004c741. You can customize this summary. It will automatically update as commits are pushed.

Copilot AI review requested due to automatic review settings June 25, 2025 23:04
@hannesrudolph hannesrudolph requested review from cte, jr and mrubens as code owners June 25, 2025 23:04
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. documentation Improvements or additions to documentation enhancement New feature or request labels Jun 25, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a persistent version indicator to the ChatView component that displays the current Roo Code version and triggers the release notes modal when clicked.

  • Added a clickable version indicator button in ChatView that shows "v{version}" and includes an aria-label for accessibility.
  • Updated internationalization for the version indicator's aria-label.
  • Revised and added tests in ChatView.spec.tsx to verify the rendering, aria-label, click behavior, and styling of the version indicator.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
webview-ui/src/i18n/locales/en/chat.json Added translation key for the version indicator aria-label.
webview-ui/src/components/chat/tests/ChatView.spec.tsx Added tests to ensure the version indicator renders correctly, has the right aria-label, and correctly triggers the Announcement modal.
webview-ui/src/components/chat/ChatView.tsx Introduced a new version indicator button that toggles the Announcement modal and refactored the scroll cleanup logic.

@delve-auditor
Copy link

delve-auditor bot commented Jun 25, 2025

No security or compliance issues detected. Reviewed everything up to 004c741.

Security Overview
  • 🔎 Scanned files: 21 changed file(s)
Detected Code Changes
Change Type Relevant files
Enhancement ► webview-ui/src/components/common/VersionIndicator.tsx
    Add version indicator component
► webview-ui/src/components/chat/ChatView.tsx
    Add version indicator to chat view
► i18n/locales/**/chat.json
    Add version indicator translations
Refactor ► packages/types/src/telemetry.ts
    Update telemetry type definitions
► packages/telemetry/src/BaseTelemetryClient.ts
    Simplify telemetry property handling
► packages/telemetry/src/PostHogTelemetryClient.ts
    Remove custom property filtering
► src/core/webview/ClineProvider.ts
    Simplify telemetry property collection
Configuration changes ► src/package.json
    Update version from 3.22.0 to 3.21.5

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jun 25, 2025
- Add clickable version indicator in top-right corner of chat view
- Clicking version opens the release notes modal (Announcement component)
- Add proper aria-label for accessibility
- Include hover effects and subtle styling
- Add comprehensive unit tests for the new functionality

Fixes #5115
@hannesrudolph hannesrudolph force-pushed the feat/issue-5115-version-indicator branch from 58205f7 to af8a95b Compare June 25, 2025 23:17
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Jun 25, 2025
@hannesrudolph
Copy link
Collaborator Author

Fixed the test file issue - restored all original tests and added new tests for the version indicator functionality. All 19 tests are now passing.

@hannesrudolph hannesrudolph moved this from Triage to PR [Needs Prelim Review] in Roo Code Roadmap Jun 25, 2025
@hannesrudolph hannesrudolph added PR - Needs Preliminary Review and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Jun 25, 2025
- Consolidate duplicate Announcement modal rendering logic
- Remove unrelated formatting changes (semicolon and trailing comma)
- Add translations for all non-English locales
- Extract version indicator into reusable VersionIndicator component
- Update tests to work with new component structure
- Change right padding from right-2 (8px) to right-3 (12px)
- Aligns with the px-3 padding pattern used in TaskHeader
- Provides proper clearance from scrollbar
- Update expected className from right-2 to right-3 in test
- Ensures test passes with the new padding value
@daniel-lxs daniel-lxs moved this from PR [Needs Prelim Review] to PR [Needs Review] in Roo Code Roadmap Jun 26, 2025
@mrubens mrubens merged commit 904e956 into main Jun 30, 2025
14 checks passed
@mrubens mrubens deleted the feat/issue-5115-version-indicator branch June 30, 2025 14:53
@github-project-automation github-project-automation bot moved this from PR [Needs Review] to Done in Roo Code Roadmap Jun 30, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jun 30, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 30, 2025
hannesrudolph added a commit that referenced this pull request Jul 3, 2025
utarn pushed a commit to modelharbor/ModelHarbor-Agent that referenced this pull request Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request lgtm This PR has been approved by a maintainer PR - Needs Review size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Add persistent version indicator on welcome screen that triggers release notes modal

4 participants