-
Notifications
You must be signed in to change notification settings - Fork 2.6k
feat: add persistent version indicator on chat screen (#5115) #5128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a persistent version indicator to the ChatView component that displays the current Roo Code version and triggers the release notes modal when clicked.
- Added a clickable version indicator button in ChatView that shows "v{version}" and includes an aria-label for accessibility.
- Updated internationalization for the version indicator's aria-label.
- Revised and added tests in ChatView.spec.tsx to verify the rendering, aria-label, click behavior, and styling of the version indicator.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| webview-ui/src/i18n/locales/en/chat.json | Added translation key for the version indicator aria-label. |
| webview-ui/src/components/chat/tests/ChatView.spec.tsx | Added tests to ensure the version indicator renders correctly, has the right aria-label, and correctly triggers the Announcement modal. |
| webview-ui/src/components/chat/ChatView.tsx | Introduced a new version indicator button that toggles the Announcement modal and refactored the scroll cleanup logic. |
|
✅ No security or compliance issues detected. Reviewed everything up to 004c741. Security Overview
Detected Code Changes
Reply to this PR with |
- Add clickable version indicator in top-right corner of chat view - Clicking version opens the release notes modal (Announcement component) - Add proper aria-label for accessibility - Include hover effects and subtle styling - Add comprehensive unit tests for the new functionality Fixes #5115
58205f7 to
af8a95b
Compare
|
Fixed the test file issue - restored all original tests and added new tests for the version indicator functionality. All 19 tests are now passing. |
- Consolidate duplicate Announcement modal rendering logic - Remove unrelated formatting changes (semicolon and trailing comma) - Add translations for all non-English locales - Extract version indicator into reusable VersionIndicator component - Update tests to work with new component structure
- Change right padding from right-2 (8px) to right-3 (12px) - Aligns with the px-3 padding pattern used in TaskHeader - Provides proper clearance from scrollbar
- Update expected className from right-2 to right-3 in test - Ensures test passes with the new padding value
Co-authored-by: Daniel Riccio <[email protected]>
… (RooCodeInc#5128) Co-authored-by: Daniel Riccio <[email protected]>
Description
Fixes #5115
This PR adds a persistent version indicator to the main chat screen that displays the current Roo Code version and opens the release notes modal when clicked.
Changes Made
Testing
Verification of Acceptance Criteria
Checklist
Screenshots/Demo
The version indicator appears in the top-right corner of the chat screen with subtle styling:
v{version}in small fontImportant
Adds a persistent version indicator to the chat screen with localization and comprehensive testing.
ChatView.tsx.VersionIndicatorcomponent incommon/VersionIndicator.tsx.ChatView.spec.tsx.This description was created by
for 004c741. You can customize this summary. It will automatically update as commits are pushed.