Skip to content

Conversation

@catrielmuller
Copy link
Contributor

@catrielmuller catrielmuller commented Jun 26, 2025

Related GitHub Issue

Resolve: #814

Description

The code index manager it's not refreshing the configuration automatically causing frustration to the user don't know why it's not connecting correctly

This PR ensures that CodeIndex services are automatically recreated whenever relevant configurations change, improving connection reliability.

  • Extracted service recreation logic into a private helper _recreateServices
  • Replaced inline recreation in both initialization and external settings change handlers with the new helper

Test Procedure

  • Configure the Code Index Qdrant with a wrong url
  • Save
  • This should be show an connection error msg
  • Update the config with a valid url
  • Save
  • Now should connect correctly

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Testing: New and/or updated tests have been added to cover my changes (if applicable).
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

image

Documentation Updates

Does this PR necessitate updates to user-facing documentation?

  • No documentation updates are required.
  • Yes, documentation updates are required. (Please describe what needs to be updated or link to a PR in the docs

Additional Notes

Get in Touch

Discord: catrielmuller


Important

Introduces _recreateServices() in manager.ts to handle service recreation on configuration changes, updating initialize() and handleExternalSettingsChange() methods, and modifies tests accordingly.

  • Behavior:
    • Introduces _recreateServices() in manager.ts to handle service recreation on configuration changes.
    • Replaces inline service recreation logic in initialize() and handleExternalSettingsChange() with _recreateServices().
  • Tests:
    • Updates manager.spec.ts to mock _recreateServices() and verify its invocation during configuration changes.
    • Ensures handleExternalSettingsChange() does not throw errors when manager is uninitialized or config manager is unset.

This description was created by Ellipsis for 48043aa. You can customize this summary. It will automatically update as commits are pushed.

@catrielmuller catrielmuller requested review from cte, jr and mrubens as code owners June 26, 2025 19:59
@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jun 26, 2025
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jun 26, 2025
@daniel-lxs daniel-lxs moved this from Triage to PR [Needs Prelim Review] in Roo Code Roadmap Jun 26, 2025
@hannesrudolph hannesrudolph added PR - Needs Preliminary Review and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Jun 26, 2025
@dosubot dosubot bot added the bug Something isn't working label Jun 26, 2025
Copy link
Member

@daniel-lxs daniel-lxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @catrielmuller!

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 27, 2025
@daniel-lxs daniel-lxs moved this from PR [Needs Prelim Review] to PR [Needs Review] in Roo Code Roadmap Jun 27, 2025
@mrubens mrubens merged commit 426518b into RooCodeInc:main Jun 27, 2025
32 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jun 27, 2025
@github-project-automation github-project-automation bot moved this from PR [Needs Review] to Done in Roo Code Roadmap Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer PR - Needs Review size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Codebase Indexing Doesn't Support Specifying an Alternative Qdrant Port and Silently Ignores It

4 participants