-
Notifications
You must be signed in to change notification settings - Fork 2.6k
fix: resolve URL loading timeout issues in @ mentions #5160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
40156b6
fix: resolve URL loading timeout issues in @ mentions
MuriloFP 88f8340
Update src/core/mentions/index.ts
MuriloFP 3a3975c
Merge branch 'RooCodeInc:main' into fix-URL-loading
MuriloFP 6e101bc
fix: use type-safe error message access in URL mention error handling
MuriloFP 8e3f9bb
fix: improve URL loading timeout handling and error messages
daniel-lxs ba8b8d8
fix: remove unnecessary security-disabling Puppeteer flags
daniel-lxs 256e748
fix: address PR review comments
daniel-lxs 3e493c8
fix: resolve test failures in UrlContentFetcher and mentions
daniel-lxs f481f6e
fix: handle platform-specific path separators in UrlContentFetcher test
daniel-lxs 20e0d93
refactor: use serialize-error for robust error handling in UrlContent…
daniel-lxs a1d33b5
fix: improve error handling in parseMentions for better user feedback…
daniel-lxs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.