-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Add default project name field to gemini-cli settings #5178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default project name field to gemini-cli settings #5178
Conversation
|
Please note that I was unable to test this on a free plan as I don't have a google account on the free plan available. |
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
daniel-lxs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @netham45, thank you for your contribution!
I left a question regarding the current Gemini CLI project ID field.
Curious to hear your thoughts on it!
|
|
||
| // Start with a default project ID (can be anything for personal OAuth) | ||
| const initialProjectId = "default" | ||
| const initialProjectId = this.options.geminiCliDefaultProject || "default" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if we could simplify this by using the existing geminiCliProjectId field for both purposes instead of adding a new field?
The approach could be:
- If
geminiCliProjectIdis set, use it as the initial value for discovery - If discovery succeeds and returns a different ID, update to use that
- If discovery fails, fall back to using the provided value directly
This would avoid having two fields that serve similar purposes, which could be confusing for users. They would just set their Google Cloud Project name in geminiCliProjectId, and the discovery process would handle converting it to the proper format if needed.
What do you think? Would this approach work for the paid tier use case you're addressing?
|
There is no longer a gemini cli provider. Closing. thank you for your contribution. |
Related GitHub Issue
Closes: #5177
Description
This adds the default project name as a user-customizable field in settings. If this is set by the user the user will be able to use paid tiers of Gemini Code Assist,.
Test Procedure
I have a 'Standard' tier gemini code assist plan on a personal account. Without this set I am unable to make any requests from the account like how an unlicensed account can, every request gives a 403 and says it is not using a valid project. Once I set a project name that has a Google Gemini Code Assist Standard license applied in the field it then works.
Pre-Submission Checklist
Screenshots / Videos
Documentation Updates
Additional Notes
Get in Touch
netham45
Important
Add
geminiCliDefaultProjectfield to Gemini CLI settings for user-customizable default project name.geminiCliDefaultProjectfield togeminiCliSchemainprovider-settings.tsfor user-customizable default project name.GeminiCliHandleringemini-cli.tsto usegeminiCliDefaultProjectas initial project ID.geminiCliDefaultProjectinGeminiCli.tsx.defaultProjectanddefaultProjectDescriptiontranslations insettings.json.This description was created by
for 34a4e2e. You can customize this summary. It will automatically update as commits are pushed.