-
Notifications
You must be signed in to change notification settings - Fork 2.6k
add todo tool #5182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add todo tool #5182
Conversation
f945997 to
905f876
Compare
|
great idea I have found that telling it to create a checklist before making large sets of changes is very effective.
|
|
Cool idea! So which PR wins? Yours or roomotes? |
@roomote is a bot, so while you might get inspiration from something that it does if you like the idea, detinitely go with the human! |
|
Thanks for the feedback! I understand you'd prefer to go with the human implementation over the bot's approach. I'll review the current todo tool implementation and ensure it's ready for integration. Let me know if there are any specific aspects you'd like me to focus on or improve. |
|
This looks good! |
KJ7LNW
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please see the comments below, mostly this is about organization to keep Task.ts from getting too big to manage.
@mrubens @KJ7LNW thanks for review I’ve done some refactoring to make it less like a prototype. The changes include:
I haven’t fixed the unit tests yet because I’m not sure if further changes to the prompt are needed. |
Related GitHub Issue
Closes: #5181
Description
When performing complex tasks, the model may miss certain steps during execution. To address this issue, a todo list tool can be introduced to remind the model of the current todo list and progress during the execution process, helping ensure that no steps are missed.
Test Procedure
prompt:
Pre-Submission Checklist
Screenshots / Videos
Documentation Updates
Additional Notes
Get in Touch
Important
Introduces a todo list tool to track task progress, with UI updates for displaying and editing todos, and settings for automatic approval.
update_todo_listtool to manage task's todo list.UpdateTodoListToolBlockfor displaying/editing todos.ChatRowandTaskHeaderto include todo list display.alwaysAllowUpdateTodoListsetting for automatic approval.chat.jsonandsettings.jsonfor multiple languages.todo.tsfor todo item schema and types.presentAssistantMessage.tsto handleupdate_todo_listtool.This description was created by
for 74dc06c. You can customize this summary. It will automatically update as commits are pushed.