Fix checkpoint popover not opening due to StandardTooltip wrapper conflict #5192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…flict The StandardTooltip component was incorrectly wrapping the PopoverTrigger, which prevented the popover from opening. This was introduced in PR #5098 when standardizing tooltip delays. The fix moves StandardTooltip inside PopoverTrigger (with asChild prop) so that PopoverTrigger can properly control its child element while still providing tooltip functionality. This pattern is consistent with other components like ShareButton.
dosubot
bot
added
size:XS
|
✅ No security or compliance issues detected. Reviewed everything up to 7690264. Security Overview
Detected Code Changes
Reply to this PR with |
mrubens
approved these changes
Jun 27, 2025
daniel-lxs
added a commit
that referenced
this pull request
Jun 28, 2025
Fixes popover not opening when StandardTooltip wraps PopoverTrigger. Follows the same pattern as PR #5192 for CheckpointMenu.
3 tasks
hannesrudolph
pushed a commit
that referenced
this pull request
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the checkpoint popover that stopped opening when clicked.
Problem
The
StandardTooltipcomponent was incorrectly wrapping thePopoverTrigger, which prevented the popover from opening. This was introduced in PR #5098 when standardizing tooltip delays across the application.Solution
Moved
StandardTooltipinsidePopoverTrigger(withasChildprop) so thatPopoverTriggercan properly control its child element while still providing tooltip functionality.Changes
CheckpointMenu.tsxto placeStandardTooltipinsidePopoverTriggerrather than wrapping itShareButtonTesting
StandardTooltipwithPopoverTrigger- no other instances of this issue foundRelated Issues
Fixes #5173
Regression from #5098
Important
Fixes popover opening issue in
CheckpointMenu.tsxby reorderingStandardTooltipandPopoverTrigger.CheckpointMenu.tsxby movingStandardTooltipinsidePopoverTrigger.PopoverTriggercan control its child element while maintaining tooltip functionality.StandardTooltipwithPopoverTriggerfor similar issues.This description was created by
for 7690264. You can customize this summary. It will automatically update as commits are pushed.