fix: restore JSON backwards compatibility for .roomodes files #5199
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes JSON backwards compatibility issue introduced in #5099.
Changes
parseYamlSafelyfor reading old JSON.roomodesfilesdefaultStringType: 'PLAIN'from allyaml.stringifycalls to ensure JSON-compatible outputTesting
All existing tests pass (18/18).
Related Issues
Closes #5180
Closes #5139
Important
Adds JSON fallback for
.roomodesfiles and ensures JSON-compatible YAML output by removingdefaultStringType: 'PLAIN'.parseYamlSafely()inCustomModesManager.tsfor.roomodesfiles.defaultStringType: 'PLAIN'fromyaml.stringifycalls inCustomModesManager.ts,SimpleInstaller.ts, andmigrateSettings.tsfor JSON-compatible output.This description was created by
for ea6bc15. You can customize this summary. It will automatically update as commits are pushed.