fix: move StandardTooltip inside PopoverTrigger in ShareButton #5203
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the share button popover that wasn't opening when clicked.
Problem
The
StandardTooltipwas wrappingPopoverTrigger, which prevented the popover from opening. This is the same issue that was fixed in PR #5192 for CheckpointMenu.Solution
Moved
StandardTooltipinsidePopoverTrigger(withasChildprop) so thatPopoverTriggercan properly control its child element while still providing tooltip functionality.Changes
ShareButton.tsxto placeStandardTooltipinsidePopoverTriggerTesting
Related Issues
Follows the same pattern as #5192
Important
Fixes popover issue in
ShareButton.tsxby movingStandardTooltipinsidePopoverTrigger.ShareButton.tsxby movingStandardTooltipinsidePopoverTrigger.This description was created by
for c55784d. You can customize this summary. It will automatically update as commits are pushed.