Skip to content

Conversation

@mrubens
Copy link
Collaborator

@mrubens mrubens commented Jun 28, 2025

Important

Prevents double-capturing of telemetry events in Task.ts by checking if messages were already captured before sending to CloudService.

  • Behavior:
    • Prevents double-capturing of telemetry events in Task.ts by checking if a message was already captured before sending to CloudService.
    • Specifically, in updateClineMessage(), checks if previousMessage exists and is not partial before capturing the event.
  • Misc:
    • Adds comments to clarify the conditions under which telemetry events are captured.

This description was created by Ellipsis for b82bd88. You can customize this summary. It will automatically update as commits are pushed.

@mrubens mrubens requested review from cte and jr as code owners June 28, 2025 04:27
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jun 28, 2025
@delve-auditor
Copy link

delve-auditor bot commented Jun 28, 2025

No security or compliance issues detected. Reviewed everything up to b82bd88.

Security Overview
  • 🔎 Scanned files: 1 changed file(s)
Detected Code Changes
Change Type Relevant files
Bug Fix ► Task.ts
    Prevent duplicate telemetry capture for cloud messages

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jun 28, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 28, 2025
@mrubens mrubens merged commit 8bb7ef0 into main Jun 28, 2025
23 checks passed
@mrubens mrubens deleted the stop_double_capturing_cloud_telemetry branch June 28, 2025 04:49
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jun 28, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Jun 28, 2025
mrubens added a commit that referenced this pull request Jun 28, 2025
utarn pushed a commit to modelharbor/ModelHarbor-Agent that referenced this pull request Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants