From ada6924b75b62f3f17b37ec52023bd62df778321 Mon Sep 17 00:00:00 2001
From: hannesrudolph <hrudolph@gmail.com>
Date: Mon, 30 Jun 2025 09:37:29 -0600
Subject: [PATCH] feat: add translation workflow to issue-fixer mode

- Added step 7 to check for translation requirements after implementation
- Integrated translation mode delegation for user-facing content changes
- Updated best practices to include translation task delegation
- Ensures all new strings, error messages, and documentation are properly localized
---
 .roo/rules-issue-fixer/1_Workflow.xml       | 70 ++++++++++++++++++---
 .roo/rules-issue-fixer/2_best_practices.xml |  3 +
 2 files changed, 64 insertions(+), 9 deletions(-)

diff --git a/.roo/rules-issue-fixer/1_Workflow.xml b/.roo/rules-issue-fixer/1_Workflow.xml
index 40971a10647..ed1e64be160 100644
--- a/.roo/rules-issue-fixer/1_Workflow.xml
+++ b/.roo/rules-issue-fixer/1_Workflow.xml
@@ -252,11 +252,63 @@
       - [ ] No linting errors
       
       If any criteria fail, return to implementation step.
-    </instructions>
-  </step>
-
-  <step number="7">
-    <name>Run Tests and Checks</name>
+     </instructions>
+   </step>
+ 
+   <step number="7">
+     <name>Check for Translation Requirements</name>
+     <instructions>
+       After implementing changes, analyze if any translations are required:
+       
+       Translation is needed if the implementation includes:
+       1. New user-facing text strings in UI components
+       2. New error messages or user notifications
+       3. Updated documentation files that need localization
+       4. New command descriptions or tooltips
+       5. Changes to announcement files or release notes
+       6. New configuration options with user-visible descriptions
+       
+       Check for these patterns:
+       - Hard-coded strings in React components (.tsx/.jsx files)
+       - New entries needed in i18n JSON files
+       - Updated markdown documentation files
+       - New VSCode command contributions
+       - Changes to user-facing configuration schemas
+       
+       If translations are required:
+       
+       <new_task>
+       <mode>translate</mode>
+       <message>Translation needed for issue #[issue-number] implementation.
+ 
+       The following changes require translation into all supported languages:
+ 
+       **Files with new/updated user-facing content:**
+       - [List specific files and what content needs translation]
+       - [Include context about where the strings appear]
+       - [Note any special formatting or constraints]
+ 
+       **Translation scope:**
+       - [Specify if it's new strings, updated strings, or both]
+       - [List specific JSON keys that need attention]
+       - [Note any markdown files that need localization]
+ 
+       **Context for translators:**
+       - [Explain the feature/fix being implemented]
+       - [Provide context about how the text is used]
+       - [Note any technical terms or constraints]
+ 
+       Please ensure all translations maintain consistency with existing terminology and follow the project's localization guidelines.</message>
+       </new_task>
+       
+       Wait for the translation task to complete before proceeding to testing.
+       
+       If no translations are required, continue to the next step.
+     </instructions>
+   </step>
+ 
+   <step number="8">
+     <name>Run Tests and Checks</name>
     <instructions>
       Run comprehensive tests to ensure quality:
       
@@ -289,7 +341,7 @@
     </instructions>
   </step>
 
-  <step number="8">
+  <step number="9">
     <name>Prepare Summary</name>
     <instructions>
       Create a comprehensive summary of the implementation:
@@ -341,7 +393,7 @@
     </instructions>
   </step>
 
-  <step number="9">
+  <step number="10">
     <name>Prepare for Pull Request</name>
     <instructions>
       If user wants to create a pull request, prepare everything needed:
@@ -429,7 +481,7 @@
     </instructions>
   </step>
 
-  <step number="10">
+  <step number="11">
     <name>Create Pull Request</name>
     <instructions>
       Once user approves, create the pull request using GitHub MCP:
@@ -492,7 +544,7 @@
     </instructions>
   </step>
 
-  <step number="11">
+  <step number="12">
     <name>Monitor PR Checks</name>
     <instructions>
       After the PR is created, monitor the CI/CD checks to ensure they pass:
diff --git a/.roo/rules-issue-fixer/2_best_practices.xml b/.roo/rules-issue-fixer/2_best_practices.xml
index 7d3a87aa9a2..dede40a92f5 100644
--- a/.roo/rules-issue-fixer/2_best_practices.xml
+++ b/.roo/rules-issue-fixer/2_best_practices.xml
@@ -12,4 +12,7 @@
   - Update documentation when needed
   - Add tests for any new functionality
   - Check for accessibility issues (for UI changes)
+  - Delegate translation tasks to translate mode when implementing user-facing changes
+  - Always check for hard-coded strings and internationalization needs
+  - Wait for translation completion before proceeding to final testing
 </best_practices>
\ No newline at end of file