Skip to content

Conversation

@mrubens
Copy link
Collaborator

@mrubens mrubens commented Jul 2, 2025

Important

Add .vscode/** to write-protected patterns in RooProtectedController.ts and update tests.

  • Behavior:
    • Add .vscode/** to PROTECTED_PATTERNS in RooProtectedController.ts to protect all files in .vscode directory.
  • Tests:
    • Add test case in RooProtectedController.spec.ts to verify .vscode directory files are write-protected.
    • Update getProtectedPatterns test in RooProtectedController.spec.ts to include .vscode/**.

This description was created by Ellipsis for 023f83b. You can customize this summary. It will automatically update as commits are pushed.

@mrubens mrubens requested review from cte and jr as code owners July 2, 2025 16:41
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 2, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 2, 2025
@delve-auditor
Copy link

delve-auditor bot commented Jul 2, 2025

No security or compliance issues detected. Reviewed everything up to 023f83b.

Security Overview
  • 🔎 Scanned files: 2 changed file(s)
Detected Code Changes
Change Type Relevant files
Enhancement ► RooProtectedController.ts
    Add .vscode directory to protected paths
► RooProtectedController.spec.ts
    Add tests for .vscode directory protection
Bug Fix ► MermaidButton.tsx
    Update background color for button container

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jul 2, 2025
daniel-lxs
daniel-lxs previously approved these changes Jul 2, 2025
@daniel-lxs daniel-lxs moved this from Triage to PR [Needs Review] in Roo Code Roadmap Jul 2, 2025
@daniel-lxs daniel-lxs dismissed their stale review July 2, 2025 16:49

Failing unit test

@hannesrudolph hannesrudolph added PR - Needs Review and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Jul 2, 2025
@mrubens mrubens merged commit 3993406 into main Jul 2, 2025
11 checks passed
@mrubens mrubens deleted the add_vscode_dir_to_write_protected branch July 2, 2025 17:17
@github-project-automation github-project-automation bot moved this from PR [Needs Review] to Done in Roo Code Roadmap Jul 2, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jul 2, 2025
utarn pushed a commit to modelharbor/ModelHarbor-Agent that referenced this pull request Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer PR - Needs Review size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants