Skip to content

Conversation

@mrubens
Copy link
Collaborator

@mrubens mrubens commented Jul 2, 2025

Important

Adds write-protection check in applyDiffToolLegacy() and modifies approval process accordingly.

  • Behavior:
    • Adds check for write-protected files in applyDiffToolLegacy() in applyDiffTool.ts using isWriteProtected().
    • Includes isProtected status in the approval message and affects askApproval() call.
  • Misc:
    • Modifies askApproval() to accept isWriteProtected as an argument.

This description was created by Ellipsis for c85f7fb. You can customize this summary. It will automatically update as commits are pushed.

@mrubens mrubens requested review from cte and jr as code owners July 2, 2025 17:36
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 2, 2025
@delve-auditor
Copy link

delve-auditor bot commented Jul 2, 2025

No security or compliance issues detected. Reviewed everything up to c85f7fb.

Security Overview
  • 🔎 Scanned files: 1 changed file(s)
Detected Code Changes
Change Type Relevant files
Enhancement ► applyDiffTool.ts
    Add file protection check in single apply diff

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

@daniel-lxs daniel-lxs moved this from Triage to PR [Needs Prelim Review] in Roo Code Roadmap Jul 2, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 2, 2025
@mrubens mrubens merged commit 1be6fce into main Jul 2, 2025
23 checks passed
@mrubens mrubens deleted the write_protect_legacy_apply_diff branch July 2, 2025 17:52
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jul 2, 2025
@github-project-automation github-project-automation bot moved this from PR [Needs Prelim Review] to Done in Roo Code Roadmap Jul 2, 2025
utarn pushed a commit to modelharbor/ModelHarbor-Agent that referenced this pull request Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer PR - Needs Preliminary Review size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants