Thanks for working on this fix! The issue you're addressing is definitely valid - we should respect .gitignore files throughout the repository hierarchy, not just in the current directory.

I noticed we already have simple-git as a dependency in the project. Have you considered using its built-in gitignore functionality instead? It has a checkIgnore() method that handles all the git traversal logic internally. This could simplify the implementation significantly.

For example, something like:

import simpleGit from 'simple-git';

const git = simpleGit(repoRoot);
const ignoredFiles = await git.checkIgnore(filePaths);

This would eliminate the need for manual directory traversal, finding the git root, and parsing multiple .gitignore files. The simple-git library already handles all of that complexity for us.

What do you think about this approach? It might make the code more maintainable while achieving the same goal.

@daniel-lxs I updated the code to use simple-git as per suggestion. It is now using git ls-file as primary method of listing files. If workspace is not git repo, it will use the previous ripgrep implementation with filtering done by ignore. I also added a final fallback on that very slim chance that ripgrep binary goes missing.

Overall, I think these changes + the added unit and integration tests make list-files very robust.

Hey @X9VoiD, really appreciate your contribution! It looks like the fix in #5394 ends up covering the same issue and is a bit more aligned with how we want to handle it. Sorry, that's my bad for now checking that PR before asking for changes on yours - thanks again for taking the time to work on this!