From 4924668d8507cb6113db588312f42b6026096130 Mon Sep 17 00:00:00 2001
From: Philip Vasilevski <phil@mauinewyork.com>
Date: Mon, 7 Jul 2025 21:12:33 +0200
Subject: [PATCH] Fix browser mode JSON snippets appearing in chat

---
 webview-ui/src/components/chat/ChatRow.tsx  | 31 +++++++++++++++++++++
 webview-ui/src/components/chat/ChatView.tsx | 26 +++++++++++++----
 2 files changed, 51 insertions(+), 6 deletions(-)

diff --git a/webview-ui/src/components/chat/ChatRow.tsx b/webview-ui/src/components/chat/ChatRow.tsx
index 9c90da503f..93ac5284fa 100644
--- a/webview-ui/src/components/chat/ChatRow.tsx
+++ b/webview-ui/src/components/chat/ChatRow.tsx
@@ -1109,6 +1109,37 @@ export const ChatRowContent = ({
 					return <CodebaseSearchResultsDisplay query={query} results={results} />
 				case "user_edit_todos":
 					return <UpdateTodoListToolBlock userEdited onChange={() => {}} />
+				case "browser_action_result":
+					// This should not normally be rendered here as browser_action_result messages
+					// should be grouped into browser sessions and rendered by BrowserSessionRow.
+					// If we see this, it means the message grouping logic has a bug.
+					return (
+						<>
+							{title && (
+								<div style={headerStyle}>
+									{icon}
+									{title}
+								</div>
+							)}
+							<div style={{ paddingTop: 10 }}>
+								<div
+									style={{
+										color: "var(--vscode-errorForeground)",
+										fontFamily: "monospace",
+										fontSize: "12px",
+										padding: "8px",
+										backgroundColor: "var(--vscode-editor-background)",
+										border: "1px solid var(--vscode-editorError-border)",
+										borderRadius: "4px",
+										marginBottom: "8px",
+									}}>
+									⚠️ Browser action result not properly grouped - this is a bug in the message
+									grouping logic
+								</div>
+								<Markdown markdown={message.text} partial={message.partial} />
+							</div>
+						</>
+					)
 				default:
 					return (
 						<>
diff --git a/webview-ui/src/components/chat/ChatView.tsx b/webview-ui/src/components/chat/ChatView.tsx
index 84bb7b89a2..8de672fed4 100644
--- a/webview-ui/src/components/chat/ChatView.tsx
+++ b/webview-ui/src/components/chat/ChatView.tsx
@@ -1034,6 +1034,18 @@ const ChatViewComponent: React.ForwardRefRenderFunction<ChatViewRef, ChatViewPro
 		}
 
 		visibleMessages.forEach((message) => {
+			// Special handling for browser_action_result - ensure it's always in a browser session
+			if (message.say === "browser_action_result" && !isInBrowserSession) {
+				isInBrowserSession = true
+				currentGroup = []
+			}
+
+			// Special handling for browser_action - ensure it's always in a browser session
+			if (message.say === "browser_action" && !isInBrowserSession) {
+				isInBrowserSession = true
+				currentGroup = []
+			}
+
 			if (message.ask === "browser_action_launch") {
 				// Complete existing browser session if any.
 				endBrowserSession()
@@ -1063,12 +1075,14 @@ const ChatViewComponent: React.ForwardRefRenderFunction<ChatViewRef, ChatViewPro
 
 				if (isBrowserSessionMessage(message)) {
 					currentGroup.push(message)
-
-					// Check if this is a close action
-					if (message.say === "browser_action") {
-						const browserAction = JSON.parse(message.text || "{}") as ClineSayBrowserAction
-						if (browserAction.action === "close") {
-							endBrowserSession()
+					if (message.say === "browser_action_result") {
+						// Check if the previous browser_action was a close action
+						const lastBrowserAction = [...currentGroup].reverse().find((m) => m.say === "browser_action")
+						if (lastBrowserAction) {
+							const browserAction = JSON.parse(lastBrowserAction.text || "{}") as ClineSayBrowserAction
+							if (browserAction.action === "close") {
+								endBrowserSession()
+							}
 						}
 					}
 				} else {