Skip to content

Conversation

@daniel-lxs
Copy link
Member

@daniel-lxs daniel-lxs commented Jul 8, 2025

Description

This PR moves codebase indexing out of experimental settings and makes it always enabled by default.

Changes

  • Removed the codebase indexing checkbox from experimental settings UI
  • Set codebaseIndexEnabled to true by default across all configuration files
  • Updated isFeatureEnabled in config-manager to always return true
  • Removed the message handler for toggling codebase index setting
  • Updated all related tests to reflect the always-enabled state
  • Removed the isEnabled property from CodeIndexConfig interface and simplified the configuration logic

Impact

Users will no longer see the codebase indexing option in experimental settings. The feature will be enabled by default for all users, though they can still configure the indexing settings (provider, model, etc.) through the existing configuration UI.

Testing

  • All existing tests have been updated and are passing
  • Linting checks pass for both frontend and backend
  • Type checking passes
  • No TypeScript errors or warnings

Important

Codebase indexing is now always enabled, removed from experimental settings, with updated configurations, UI, and tests.

  • Behavior:
    • Codebase indexing is now always enabled, removed from experimental settings.
    • codebaseIndexEnabled set to true by default in ClineProvider.ts and CodeIndexPopover.tsx.
    • isFeatureEnabled in config-manager.ts always returns true.
    • Removed message handler for toggling codebase index setting in webviewMessageHandler.ts.
  • Configuration:
    • Removed isEnabled from CodeIndexConfig interface.
    • Simplified configuration logic in config-manager.ts.
  • UI:
    • Removed codebase indexing checkbox from ExperimentalSettings.tsx.
    • Updated CodeIndexPopover.tsx to reflect always-enabled state.
  • Testing:
    • Updated tests in config-manager.spec.ts and manager.spec.ts to reflect always-enabled state.
    • Tests ensure no restart is required when settings are unchanged.

This description was created by Ellipsis for d6d646f. You can customize this summary. It will automatically update as commits are pushed.

@delve-auditor
Copy link

delve-auditor bot commented Jul 8, 2025

No security or compliance issues detected. Reviewed everything up to d6d646f.

Security Overview
  • 🔎 Scanned files: 11 changed file(s)
Detected Code Changes
Change Type Relevant files
Enhancement ► ClineProvider.ts
    Enable codebase indexing by default
► config-manager.ts
    Make codebase indexing always enabled
► webviewMessageHandler.ts
    Remove codebase index enable/disable toggle
► ExperimentalSettings.tsx
    Remove codebase index toggle from UI
Refactor ► config-manager.ts
    Streamline configuration change checks

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jul 8, 2025
- Remove codebase indexing checkbox from experimental settings
- Set codebase indexing enabled by default (true)
- Update all default values and tests to reflect always-enabled state
- Remove message handler for toggling codebase index setting
- Remove isEnabled property from CodeIndexConfig interface
- Remove isEnabled field from config-manager.ts
- Simplify restart detection logic since feature is always enabled
- Update all tests to remove isEnabled references
- Feature is now always enabled, configuration status is the only check needed
@daniel-lxs daniel-lxs force-pushed the feat/move-codebase-indexing-out-of-experimental branch from 56ab42b to d6d646f Compare July 9, 2025 02:57
@daniel-lxs daniel-lxs marked this pull request as ready for review July 9, 2025 02:58
@daniel-lxs daniel-lxs requested review from cte, jr and mrubens as code owners July 9, 2025 02:58
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jul 9, 2025
@daniel-lxs daniel-lxs moved this from Triage to PR [Needs Review] in Roo Code Roadmap Jul 9, 2025
@mrubens mrubens merged commit 09e348e into main Jul 9, 2025
22 checks passed
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 9, 2025
@mrubens mrubens deleted the feat/move-codebase-indexing-out-of-experimental branch July 9, 2025 03:07
@github-project-automation github-project-automation bot moved this from PR [Needs Review] to Done in Roo Code Roadmap Jul 9, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants