Fix Azure OpenAI API version duplication #5806
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add URL parsing utility to extract API version from Base URL - Modify OpenAI provider to use extracted API version when azureApiVersion field is not set - Update UI to show helpful message when API version is detected in URL - Add comprehensive tests for URL parsing functionality Fixes #5805
dosubot
bot
added
the
size:L
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| const baseUrl = apiConfiguration?.openAiBaseUrl || "" | ||
| const extractedApiVersion = extractApiVersionFromUrl(baseUrl) | ||
| const isAzureUrl = isAzureOpenAiUrl(baseUrl) | ||
| const showApiVersionExtraction = isAzureUrl && extractedApiVersion && !azureApiVersionSelected |
Contributor
There was a problem hiding this comment.
The variable 'showApiVersionExtraction' is computed based on the extracted API version from the Base URL but is not used anywhere in the UI. Consider using it to display a notice (or auto-fill the Azure API version field) to help users understand that the API version was detected from their Base URL, thereby reducing configuration duplication.
hannesrudolph
added
the
Issue/PR - Triage
- Fix security vulnerability in URL validation by using endsWith instead of includes - Add UI notification for detected API version from Base URL - Add validation for Azure API version format - Improve test coverage with edge cases - Exclude Azure AI Inference Service URLs from Azure OpenAI detection
webview-ui/src/components/settings/providers/OpenAICompatible.tsx
Outdated
Show resolved
Hide resolved
- Add translation key 'azureApiVersionDetected' to English locale - Update OpenAICompatible component to use translation function - Addresses Ellipsis bot comment about internationalization
- Improve Azure URL detection logic to be more specific - Add visual validation for manually entered Azure API versions in UI - Import isValidAzureApiVersion function for input validation - Add border color styling to indicate valid/invalid API version format
- Added translations for 'azureApiVersionDetected' key in all supported languages - Translations inform users when API version is auto-detected from Base URL - Covers languages: ca, de, es, fr, hi, id, it, ja, ko, nl, pl, pt-BR, ru, tr, vi, zh-CN, zh-TW
hannesrudolph
added
PR - Needs Preliminary Review
and removed
Issue/PR - Triage
- Extract API version from URL for both Azure OpenAI and Azure AI Inference - Keep original URL unchanged to maintain backward compatibility - API version is still sent in both URL and parameter as before - Only the user experience changes (no need to specify version twice)
daniel-lxs
approved these changes
Jul 19, 2025
Member
daniel-lxs
left a comment
daniel-lxs
left a comment
There was a problem hiding this comment.
Looks good but can't really test with Azure
daniel-lxs
moved this from PR [Needs Prelim Review]
to PR [Needs Review]
in Roo Code Roadmap
…nai-api-version-duplication
mrubens
approved these changes
Jul 19, 2025
Collaborator
|
Has anyone been able to test this one? |
daniel-lxs
moved this from PR [Needs Review]
to PR [Draft / In Progress]
in Roo Code Roadmap
github-project-automation
bot
moved this from PR [Draft / In Progress]
to Done
in Roo Code Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5805 - Eliminates the need to specify API version in both Base URL and separate field for Azure OpenAI
Important
This PR refines Azure OpenAI API version handling by extracting the version from the URL, reducing configuration redundancy, and updating the UI to reflect detected versions.
OpenAiHandlerinopenai.tsnow extracts Azure API version from URL if not explicitly set, reducing redundancy.extractApiVersionFromUrl()and related functions inazure-url-parser.ts.azure-url-parser.test.ts.OpenAICompatible.tsxupdated to show detected API version if not manually set.This description was created by
for 0f12000. You can customize this summary. It will automatically update as commits are pushed.