Feat/issue 5293 share button next to start new task #5853
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:L
hannesrudolph
added
the
Issue/PR - Triage
hannesrudolph
added
PR - Needs Preliminary Review
and removed
Issue/PR - Triage
daniel-lxs
approved these changes
Jul 21, 2025
Member
daniel-lxs
left a comment
daniel-lxs
left a comment
There was a problem hiding this comment.
Just a couple of small suggestions
daniel-lxs
moved this from PR [Needs Prelim Review]
to PR [Changes Requested]
in Roo Code Roadmap
hannesrudolph
added
PR - Changes Requested
and removed
PR - Needs Preliminary Review
labels
Member
|
Quick question: Should the popover open where it normally does? or should we have a separate one for this new button? 
Let me know what you think |
daniel-lxs
approved these changes
Jul 22, 2025
daniel-lxs
moved this from PR [Changes Requested]
to PR [Needs Prelim Review]
in Roo Code Roadmap
daniel-lxs
moved this from PR [Needs Prelim Review]
to PR [Needs Review]
in Roo Code Roadmap
…ility (RooCodeInc#5293) - Added ShareButton component next to Start New Task button in ChatView - Share button only appears when currentTaskItem has an ID - Added comprehensive tests for the new functionality - Fixed linting issues in test file
- Simplify className logic by extracting showShareButton and buttonClassName variables as suggested by Daniel - Remove redundant null check for currentTaskItem (ShareButton handles it internally) - Create custom VSCodeButton for share functionality at the bottom to match Start New Task button style - Keep original ShareButton component unchanged for header usage - Update test mock to match actual ShareButton null-check behavior
- Extract className logic to a variable for better readability - Remove redundant null check for currentTaskItem - Style share button to match Start New Task button appearance - Add Share text with proper icon alignment - Ensure translations work correctly for all languages
- Remove text from share button (icon only) - Adjust button widths: Start New Task 90%, Share 10% - Change share button to primary appearance to match Start New Task - Maintain same height for both buttons
- Remove text from share button (icon only) - Change share button to primary appearance to match Start New Task - Ensure both buttons have the same height - Simplify layout to let buttons size naturally
- Extract className logic to a variable for better readability - Remove redundant null check for currentTaskItem - Add share button next to Start New Task with matching primary appearance - Hide original ShareButton and create custom VSCodeButton for consistent styling
daniel-lxs
force-pushed
the
feat/issue-5293-share-button-next-to-start-new-task
branch
from
5ebeab4 to
016e1b5
Compare
Collaborator
|
I'm not sure about this one. I pushed a tweak to the button padding/alignment, but a few other things I'm unsure about:
I'd probably pause on this one for now and reopen once we have a chance to discuss where we want to end up here from a product perspective. |
github-project-automation
bot
moved this from PR [Needs Review]
to Done
in Roo Code Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5293
This PR adds a share button next to the "Start New Task" button to provide quick access to the same share functionality currently available in the task header, improving discoverability as requested.
Changes Made
ShareButtoncomponent import toChatView.tsxcurrentTaskItemhas an ID (indicating there's a task to share)Testing
enableButtonsstateVerification of Acceptance Criteria
Checklist
Screenshots/Demo
The share button now appears as a square button with a link icon next to the shortened "Start New Task" button, providing improved discoverability for the share functionality.
Important
Adds a share button next to "Start New Task" in
ChatView.tsx, with tests for visibility and state management.ShareButtonnext to "Start New Task" inChatView.tsxifcurrentTaskItemhas an ID and primary button text is "Start New Task".ChatView.spec.tsxfor share button visibility and state management.enableButtonsstate.This description was created by
for 994350fb3dd16819fc2a5faea5b22a88926d9bab. You can customize this summary. It will automatically update as commits are pushed.