feat: add Mistral embedding provider for codebase indexing #5933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add Mistral as a new embedding provider option - Support for codestral-embed model with 1024 dimensions - OpenAI-compatible API integration at https://api.mistral.ai/v1 - Free tier availability for cost-effective embedding generation - Comprehensive test coverage for MistralEmbedder class - Configuration support in service factory and config manager Resolves #5932
- Add Mistral option to provider dropdown - Add Mistral API key configuration UI - Add Mistral model selection dropdown - Add validation schema for Mistral provider - Handle Mistral API key in secret management
- Add mistral to WebviewMessage type definition - Add mistral to codebase-index schema in types package - Fixes TypeScript compilation errors
- Add mistral to codebaseIndexModelsSchema - Add codebaseIndexMistralApiKey to codebaseIndexProviderSchema - Fixes TypeScript compilation errors in webview component
Closed
4 tasks
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| const openAiCompatibleBaseUrl = codebaseIndexConfig.codebaseIndexOpenAiCompatibleBaseUrl ?? "" | ||
| const openAiCompatibleApiKey = this.contextProxy?.getSecret("codebaseIndexOpenAiCompatibleApiKey") ?? "" | ||
| const geminiApiKey = this.contextProxy?.getSecret("codebaseIndexGeminiApiKey") ?? "" | ||
| const mistralApiKey = this.contextProxy?.getSecret("mistralApiKey") ?? "" |
Contributor
There was a problem hiding this comment.
The secret key for the Mistral API is fetched using getSecret("mistralApiKey"), but elsewhere (e.g. in the zod schema and UI) the mistral key is referred to as codebaseIndexMistralApiKey. Consider aligning the secret key naming for consistency to avoid potential mismatches.
Suggested change
| const mistralApiKey = this.contextProxy?.getSecret("mistralApiKey") ?? "" | |
| const mistralApiKey = this.contextProxy?.getSecret("codebaseIndexMistralApiKey") ?? "" |
dosubot
bot
added
size:L
hannesrudolph
added
the
Issue/PR - Triage
Contributor
|
Please fix the dimension to 1536 @roomote-agent |
Contributor
Author
|
Hi @shariqriazz, I see your request to fix the dimension to 1536. I'm working on this change now and will update the PR shortly. |
Contributor
Author
|
Hi @shariqriazz, I've successfully updated the Mistral codestral-embed dimension from 1024 to 1536 as requested. Changes made:
All tests are passing and CI checks have completed successfully. The changes are ready for review. |
Member
|
Mistral doesn't seem to be OpenAI compatible |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements Mistral codestral-embed model support with OpenAI-compatible API integration for improved performance and cost efficiency.
Changes
Features
Fixes #5932
Important
Adds Mistral as a new embedding provider for codebase indexing, including configuration, UI updates, and test coverage.
codebase-index.tsandconfig-manager.ts.MistralEmbedderclass inmistral.tswrappingOpenAICompatibleEmbedder.service-factory.tsandCodeIndexPopover.tsx.CodeIndexPopover.tsxto support Mistral provider selection.codebaseIndexConfigSchemaandcodebaseIndexProviderSchemaincodebase-index.tsto include Mistral.config-manager.ts.MistralEmbedderinmistral.spec.ts.MISTRAL_MAX_ITEM_TOKENSinconstants/index.ts.embeddingModels.tswithcodestral-embedmodel.This description was created by
for 3260857. You can customize this summary. It will automatically update as commits are pushed.