-
Notifications
You must be signed in to change notification settings - Fork 2.6k
feat: Add checkpoint after every message (#5995) #5996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Save checkpoints after every assistant message, not just when files are modified - Save checkpoints after user messages to preserve manual edits - Ensures user's manual changes between messages are always preserved - Addresses issue #5995 requesting automatic checkpoints after every message
| TelemetryService.instance.captureConversationMessage(this.taskId, "user") | ||
|
|
||
| // Save checkpoint after user message to preserve any manual edits | ||
| await checkpointSave(this) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A new checkpoint is saved after processing a user message. Please ensure that this call respects the 'enableCheckpoints' flag and consider wrapping 'await checkpointSave(this)' in a try/catch block to log errors rather than interrupting the task flow.
|
This should be handled differently, instead of creating a new checkpoint after each message we should simply show the same checkpoint button on all subsequent messages from the point the checkpoint was created. That way the change only needs to be made in the UI. |
Can we have a manual checkpoint option? @daniel-lxs |
@roomote-agent can you make this change? |
|
Hi @mrubens! I understand the request - instead of creating a new checkpoint after each message, we should show the same checkpoint button on all subsequent messages from the point the checkpoint was created. This would be a UI-only change. Let me investigate the current implementation and make the necessary changes. |
|
Hi @mrubens! I've implemented the requested change in PR #6273. Instead of creating new checkpoints after each message, the UI now shows the same checkpoint button on all subsequent messages from the point the checkpoint was created. This is a UI-only change as you suggested. Please take a look and let me know if this meets your requirements! |
Summary
This PR implements automatic checkpoints after every message exchange, as requested in issue #5995.
Changes
Benefits
Testing
Fixes #5995
Important
Save checkpoints after every message exchange in
presentAssistantMessage.tsandTask.ts, ensuring manual edits are preserved and removing conditional logic based on file modifications.presentAssistantMessage.tsandTask.ts, ensuring manual edits are preserved.presentAssistantMessage.ts.This description was created by
for a6888c0. You can customize this summary. It will automatically update as commits are pushed.