feat: add diffViewAutoFocus setting to control diff editor focus behavior #6011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vior - Added diffViewAutoFocus boolean setting to global settings schema - Added UI checkbox in AutoApproveSettings component - Updated ExtensionStateContext to manage the setting state - Modified DiffViewProvider to use the setting for preserveFocus parameter - Updated Task class to pass the setting to DiffViewProvider - Added comprehensive tests for the new functionality - Added i18n translations for the setting Fixes #6010
dosubot
bot
added
size:L
hannesrudolph
added
the
Issue/PR - Triage
4 tasks
- Add missing translations for diffViewAutoFocus setting to all 17 locale files - Remove unused FileEditingSettings.tsx file to fix knip issues - Fix unit test failures by updating vscode mock with missing exports (Uri, RelativePattern, onDidChangeWorkspaceFolders) - Ensure mockProvider.getState returns valid response in Task.spec.ts
Member
|
To be implemented by @felixAnhalt, closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new setting
diffViewAutoFocusthat allows users to control whether diff editors automatically gain focus when opened by Roo.Changes
diffViewAutoFocusboolean setting to global settings schema with default value offalsepreserveFocusparameterTesting
Screenshots
The new setting appears in the Auto-approve Settings section:
Fixes #6010
Important
Introduces
diffViewAutoFocussetting to control diff editor focus, with UI integration, state management, tests, and translations.diffViewAutoFocussetting to control focus behavior of diff editors, defaultfalse.DiffViewProvideruses setting forpreserveFocusparameter.ExtensionStateContextupdated to managediffViewAutoFocusstate.Taskclass updated to pass setting toDiffViewProvider.diffViewAutoFocusinDiffViewProvider.spec.tsandTask.spec.ts.diffViewAutoFocusin multiple language files.This description was created by
for 816c658. You can customize this summary. It will automatically update as commits are pushed.