fix: respect mcpEnabled setting to prevent automatic MCP server initialization #6017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ialization - Add conditional initialization in ClineProvider based on mcpEnabled setting - Update McpHub constructor to accept autoInitialize parameter - Add enableServers() and disableServers() methods for dynamic control - Handle mcpEnabled toggle in webview message handler - Update tests to cover new behavior Fixes #6014
dosubot
bot
added
size:L
hannesrudolph
added
the
Issue/PR - Triage
Member
|
The issue isn't sufficiently scoped for Roomote to address it, closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6014
Summary
This PR addresses the issue where MCP servers automatically start when the IDE loads, consuming significant memory with no way to disable them without removing the entire extension.
Changes
ClineProviderto check themcpEnabledsetting before initializing MCP HubMcpHubconstructor to accept anautoInitializeparameter (default true for backward compatibility)enableServers()anddisableServers()methods to McpHub for dynamic controlBehavior
mcpEnabledis false (default), MCP servers will not start automaticallyTesting
This implementation ensures that users have full control over MCP server initialization, preventing unwanted memory consumption while maintaining the ability to use MCP features when needed.
Important
This PR modifies MCP server initialization to respect the
mcpEnabledsetting, preventing automatic startup and allowing dynamic control via user settings.ClineProvidernow checksmcpEnabledsetting before initializing MCP Hub.McpHubconstructor updated to acceptautoInitializeparameter (default true).enableServers()anddisableServers()methods added toMcpHubfor dynamic control.McpHub.spec.ts.This description was created by
for 02bb864. You can customize this summary. It will automatically update as commits are pushed.