-
Notifications
You must be signed in to change notification settings - Fork 2.6k
feat: add star feature for tasks to prevent accidental deletion #6245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add starred field to HistoryItem type - Add star button UI component to task items - Implement toggle star functionality - Sort starred tasks to the top of the list - Prevent deletion of starred tasks with warning messages - Add batch delete protection for starred tasks - Add localization support for star-related messages Fixes #6244
| "deleteTaskMessage": "Are you sure you want to delete this task? This action cannot be undone.", | ||
| "deleteStarredTask": "Cannot Delete Starred Task", | ||
| "deleteStarredTaskMessage": "This task is starred and cannot be deleted. Please unstar it first if you want to delete it.", | ||
| "starTask": "Star task", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typographical note: The label "Star task" has inconsistent capitalization compared to similar entries (e.g. "Export Task", "Delete Task"). Consider changing it to "Star Task" for consistency.
| "starTask": "Star task", | |
| "starTask": "Star Task", |
This comment was generated because it violated a code review rule: irule_C0ez7Rji6ANcGkkX.
| "deleteStarredTask": "Cannot Delete Starred Task", | ||
| "deleteStarredTaskMessage": "This task is starred and cannot be deleted. Please unstar it first if you want to delete it.", | ||
| "starTask": "Star task", | ||
| "unstarTask": "Unstar task", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typographical note: The label "Unstar task" has inconsistent capitalization compared to similar entries (e.g. "Export Task", "Delete Task"). Consider changing it to "Unstar Task" for consistency.
| "unstarTask": "Unstar task", | |
| "unstarTask": "Unstar Task", |
This comment was generated because it violated a code review rule: irule_C0ez7Rji6ANcGkkX.
|
Closing for now as the issue needs approval and proper scoping |
1 similar comment
|
Closing for now as the issue needs approval and proper scoping |
Summary
This PR implements a star feature for tasks as requested in #6244. Users can now star important tasks to keep them at the top of the list and prevent accidental deletion.
Changes
Implementation Details
Testing
Screenshots
The star button appears on hover and shows the current starred state:
Fixes #6244
Important
Add star feature to tasks, allowing users to prioritize and protect tasks from deletion, with updates to data models, UI components, and state management.
starredfield toHistoryItemtype inhistory.ts.StarButtoncomponent for toggling star state.BatchDeleteTaskDialog.tsxandDeleteTaskDialog.tsxto handle starred tasks.TaskItemHeader.tsxto includeStarButton.webviewMessageHandler.ts.useTaskSearch.tsto prioritize starred tasks.history.json.This description was created by
for 67b29f2. You can customize this summary. It will automatically update as commits are pushed.