fix(diagnostics): differentiate linter warnings from fatal errors #6258
Conversation
…This change addresses an issue where linter errors were treated as fatal, causing unnecessary retries and inefficient file writes. The getNewDiagnostics function has been updated to categorize diagnostics into problems (fatal errors) and warnings (linter errors). The DiffViewProvider has been updated to consume this new structure and present the information to the AI in a more structured way.\n\nFixes RooCodeInc#4622
…This change addresses an issue where linter errors were treated as fatal, causing unnecessary retries and inefficient file writes. The getNewDiagnostics function has been updated to categorize diagnostics into problems (fatal errors) and warnings (linter errors). The DiffViewProvider has been updated to consume this new structure and present the information to the AI in a more structured way.\n\nFixes RooCodeInc#4622
…This change addresses an issue where linter errors were treated as fatal, causing unnecessary retries and inefficient file writes. The getNewDiagnostics function has been updated to categorize diagnostics into problems (fatal errors) and warnings (linter errors). The DiffViewProvider has been updated to consume this new structure and present the information to the AI in a more structured way.\n\nFixes RooCodeInc#4622
…This change addresses an issue where linter errors were treated as fatal, causing unnecessary retries and inefficient file writes. The getNewDiagnostics function has been updated to categorize diagnostics into problems (fatal errors) and warnings (linter errors). The DiffViewProvider has been updated to consume this new structure and present the information to the AI in a more structured way.\n\nFixes RooCodeInc#4622
…This change addresses an issue where linter errors were treated as fatal, causing unnecessary retries and inefficient file writes. The getNewDiagnostics function has been updated to categorize diagnostics into problems (fatal errors) and warnings (linter errors). The DiffViewProvider has been updated to consume this new structure and present the information to the AI in a more structured way.\n\nFixes RooCodeInc#4622
…This change addresses an issue where linter errors were treated as fatal, causing unnecessary retries and inefficient file writes. The getNewDiagnostics function has been updated to categorize diagnostics into problems (fatal errors) and warnings (linter errors). The DiffViewProvider has been updated to consume this new structure and present the information to the AI in a more structured way.\n\nFixes RooCodeInc#4622
…ncb/Roo-Code into fix/issue-4622-linter-errors
daniel-lxs
moved this from PR [Needs Prelim Review]
to PR [Draft / In Progress]
in Roo Code Roadmap
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if (typeof value === "string") { | ||
| // Only escape <, >, and & characters | ||
| return value.replace(/&/g, "&").replace(/</g, "<").replace(/>/g, ">") | ||
| return value.replace(/&/g, "&").replace(/</g, "<").replace(/>/g, ">") |
Check warning
Code scanning / CodeQL
Replacement of a substring with itself Medium
| if (typeof value === "string") { | ||
| // Only escape <, >, and & characters | ||
| return value.replace(/&/g, "&").replace(/</g, "<").replace(/>/g, ">") | ||
| return value.replace(/&/g, "&").replace(/</g, "<").replace(/>/g, ">") |
Check warning
Code scanning / CodeQL
Replacement of a substring with itself Medium
| if (typeof value === "string") { | ||
| // Only escape <, >, and & characters | ||
| return value.replace(/&/g, "&").replace(/</g, "<").replace(/>/g, ">") | ||
| return value.replace(/&/g, "&").replace(/</g, "<").replace(/>/g, ">") |
Check warning
Code scanning / CodeQL
Replacement of a substring with itself Medium
| if (typeof value === "string") { | ||
| // Only escape <, >, and & characters | ||
| return value.replace(/&/g, "&").replace(/</g, "<").replace(/>/g, ">") | ||
| return value.replace(/&/g, "&").replace(/</g, "<").replace(/>/g, ">") |
Check warning
Code scanning / CodeQL
Replacement of a substring with itself Medium
| if (typeof value === "string") { | ||
| // Only escape <, >, and & characters | ||
| return value.replace(/&/g, "&").replace(/</g, "<").replace(/>/g, ">") | ||
| return value.replace(/&/g, "&").replace(/</g, "<").replace(/>/g, ">") |
Check warning
Code scanning / CodeQL
Replacement of a substring with itself Medium
| if (typeof value === "string") { | ||
| // Only escape <, >, and & characters | ||
| return value.replace(/&/g, "&").replace(/</g, "<").replace(/>/g, ">") | ||
| return value.replace(/&/g, "&").replace(/</g, "<").replace(/>/g, ">") |
Check warning
Code scanning / CodeQL
Replacement of a substring with itself Medium
dosubot
bot
added
size:L
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| indentBy: "", | ||
| suppressEmptyNode: true, | ||
| processEntities: false, | ||
| tagValueProcessor: (name, value) => { |
There was a problem hiding this comment.
The XMLBuilder processors now simply return the original characters (e.g. replacing '&' with '&'). This does not perform proper XML escaping. It should replace '&' with '&', '<' with '<', and '>' with '>' to prevent XML injection issues.
daniel-lxs
moved this from PR [Draft / In Progress]
to PR [Needs Prelim Review]
in Roo Code Roadmap
hannesrudolph
added
PR - Needs Preliminary Review
and removed
PR - Draft / In Progress
labels
|
Hey @emincb Thank you for the time you put into this, we really appreciate it. However I don't think this is a problem anymore, the issue was with Gemini 2.5 Flash but I haven't heard about this issue again, have you experienced it? do you have any examples of it? The main issue is that I'm unable to replicate the issue so I don't know if this will fix it or not. I'll close it for now but please let me know if you have more information about it. |
github-project-automation
bot
moved this from PR [Needs Prelim Review]
to Done
in Roo Code Roadmap
I’ve been encountering the errors mentioned in the issue above almost daily. The model used here is Gemini 2.5 Pro. There’s definitely something wrong with the combination of Pylance, Roo Code, and the model, because for me the reproducibility rate is close to 100%.
This started happening after the updates over the past two weeks, as far as I know. The model has been costing almost five times more on similar tasks, only to get stuck on linter errors. |
3 participants
This change addresses an issue where linter errors were treated as fatal, causing unnecessary retries and inefficient file writes. The getNewDiagnostics function has been updated to categorize diagnostics into problems (fatal errors) and warnings (linter errors). The DiffViewProvider has been updated to consume this new structure and present the information to the AI in a more structured way. Fixes #4622
Important
Differentiate linter warnings from fatal errors in diagnostics to improve efficiency and prevent unnecessary retries.
getNewDiagnosticsinindex.tsnow categorizes diagnostics intoproblems(fatal errors) andwarnings(linter errors).DiffViewProviderinDiffViewProvider.tsupdated to handle and display newproblemsandwarningsmessages.index.test.tsto verify correct categorization of diagnostics intoproblemsandwarnings.vscode.tsmock to simulatevscodeenvironment for testing.This description was created by
for d04b46f. You can customize this summary. It will automatically update as commits are pushed.