fix: allow image pasting while task is active

[roomote]

Description

This PR fixes an issue where users were unable to paste images into the chatbox while a task was active.

Root Cause

The shouldDisableImages calculation in ChatView.tsx was including sendingDisabled in its condition. This meant that whenever sending was disabled (which happens during active tasks), image pasting was also disabled.

Solution

Removed sendingDisabled from the shouldDisableImages condition. The updated logic now only disables images when:

• Images are explicitly disabled in settings
• The current model does not support vision
• The API configuration does not support images

This allows users to paste images for context even while a task is running, improving the user experience.

Testing

• All existing tests pass ✅
• Manually tested image pasting during active tasks
• Verified that image restrictions still work correctly for non-vision models

Impact

• No breaking changes
• No side effects - This change only affects the image pasting behavior during active tasks
• Improves UX by allowing users to add visual context while tasks are running

---

Important

Fixes image pasting issue in ChatView.tsx by removing sendingDisabled from shouldDisableImages, allowing pasting during active tasks.

• Behavior:
  • Fixes image pasting issue in ChatView.tsx by removing sendingDisabled from shouldDisableImages condition.
  • Image pasting now allowed during active tasks unless images are disabled in settings, model doesn't support vision, or API doesn't support images.
• Testing:
  • All existing tests pass.
  • Manually tested image pasting during active tasks.
  • Verified image restrictions for non-vision models.

^{This description was created by for 472cf41. You can customize this summary. It will automatically update as commits are pushed.}

[roomote]

Review Summary

I've reviewed this PR and found it to be a well-focused fix that addresses the stated issue effectively. The change is minimal, logical, and preserves all other image restrictions while allowing image pasting during active tasks.

Findings

✅ Positive Observations

• Focused change: The fix is surgical and addresses exactly the issue described
• Logic is sound: Removing sendingDisabled from shouldDisableImages makes sense - sending being disabled shouldn't prevent image pasting for context
• Preserves safety: All other image restrictions remain intact (model support, settings, max images)
• No breaking changes: All existing tests pass
• Good UX improvement: Users can now add visual context while tasks are running

💡 Suggestions for Improvement

Test Coverage Enhancement
Could we add a specific test case that verifies image pasting is allowed when sendingDisabled is true but other conditions permit images? This would ensure the fix is properly covered and prevent regression.

Documentation Clarity
Consider adding a brief comment above the shouldDisableImages logic explaining when images should be disabled and why sendingDisabled was intentionally excluded.

Edge Case Consideration
Is there any concern about users pasting large images during active tasks? The current implementation handles this well with the MAX_IMAGES_PER_MESSAGE limit, but worth confirming this doesn't impact performance during task execution.

Recommendation

This is a solid fix that improves user experience without introducing risks. The suggestions above are minor enhancements that could be addressed in follow-up work if desired.

Approval Status: ✅ Ready to merge