Skip to content

Allow queueing images #6414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 30, 2025
Merged

Allow queueing images #6414

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9a280c
Improved placeholder styling
mrubens Jul 30, 2025
9fcd301
Allow queuing images
mrubens Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions webview-ui/src/components/chat/ChatTextArea.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1133,10 +1133,10 @@ const ChatTextArea = forwardRef<HTMLTextAreaElement, ChatTextAreaProps>(

{!inputValue && !isEditMode && (
<div
className="absolute left-2 z-30 pr-9 flex items-center h-8"
className="absolute left-2 z-30 pr-9 flex items-center h-8 font-vscode-font-family text-vscode-editor-font-size leading-vscode-editor-line-height"
style={{
bottom: "0.25rem",
color: "var(--vscode-tab-inactiveForeground)",
color: "color-mix(in oklab, var(--vscode-input-foreground) 50%, transparent)",
Copy link
Contributor

@roomote roomote bot Jul 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The styling improvements here are good for visual consistency. However, the color-mix() function may not be supported in older browsers. Have you considered providing a fallback color or checking browser compatibility requirements for this project?

userSelect: "none",
pointerEvents: "none",
}}>
Expand Down
3 changes: 1 addition & 2 deletions webview-ui/src/components/chat/ChatView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -811,8 +811,7 @@ const ChatViewComponent: React.ForwardRefRenderFunction<ChatViewRef, ChatViewPro

const selectImages = useCallback(() => vscode.postMessage({ type: "selectImages" }), [])

const shouldDisableImages =
!model?.supportsImages || sendingDisabled || selectedImages.length >= MAX_IMAGES_PER_MESSAGE
const shouldDisableImages = !model?.supportsImages || selectedImages.length >= MAX_IMAGES_PER_MESSAGE
Copy link
Contributor

@roomote roomote bot Jul 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change successfully enables image queueing when sending is disabled, which aligns with the PR title. However, could we add a comment here explaining why sendingDisabled was intentionally removed? This would help future maintainers understand the different behavior between text and image inputs.


const handleMessage = useCallback(
(e: MessageEvent) => {
Expand Down