-
Notifications
You must be signed in to change notification settings - Fork 2.6k
docs: document optional todos param for new_task (#6329) #6458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds documentation for the optional todos parameter in the new_task tool and clarifies the behavior of the todoListEnabled setting. The changes are purely documentation-focused, with no functional code modifications.
- Documents the existing optional
todosparameter for initializing task todo lists via markdown checklists - Clarifies that
todoListEnabledonly controls prompting behavior, not todo list initialization - Provides comprehensive examples showing usage with and without the
todosparameter
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/shared/tools.ts | Extends NewTaskToolUse interface to include "todos" parameter in type definition |
| src/core/prompts/tools/new-task.ts | Adds comprehensive documentation for todos parameter with examples and clarifications |
| Multiple snapshot files | Updates test snapshots to reflect the new documentation content |
| Parameters: | ||
| - mode: (required) The slug of the mode to start the new task in (e.g., "code", "debug", "architect"). | ||
| - message: (required) The initial user message or instructions for this new task. | ||
| - todos: (optional) A markdown checklist string to initialize the new task's todo list. Use the same single-level checklist format as update_todo_list. If provided, Task parses this during initialization to create the todoList. If omitted, the task starts without a todoList. |
Copilot
AI
Jul 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation references 'update_todo_list' format but doesn't provide a clear definition of what 'single-level checklist format' means. Consider adding a brief explanation or example of the expected format inline, such as '[ ] item text' for unchecked, '[x] item text' for checked, and '[-] item text' for in-progress items.
Review SummaryI have reviewed PR #6458 and found critical issues that need to be addressed before this can be merged. Critical Issues (Must Fix)1. Documentation without ImplementationThe PR documents a
2. Misleading PR DescriptionThe PR claims "No functional behavior changes; documentation and typing-only updates" but:
3. False InterfaceThe typing in RecommendationThis PR should either:
The current state documents non-existent functionality, which could confuse users and break their workflows. Additional ContextBased on issue #6329, the original request was for a required parameter to enable hierarchical task planning. The implementation would need:
|
Title: docs(new_task): document optional
todosparameter; clarifytodoListEnabledbehaviorSummary
Context and Motivation
This aligns documentation with current behavior validated by tests. It enables users to initialize a task’s todo list via a markdown checklist passed to new_task, and removes confusion around the todoListEnabled setting.
Changes
Non-Goals
Testing
Automated
Manual
Docs
Screenshots/Demos
N/A (documentation-only changes).
Backward Compatibility
Risks
Checklist
Linked Issue
todosparameter to new_task tool for hierarchical task planning #6329Important
Document optional
todosparameter fornew_tasktool and update related typings and snapshots.todosparameter innew_tasktool innew-task.ts.new_taskusage with and withouttodos.todoListEnabledsetting only affects prompting, not initialization.NewTaskToolUse.paramsintools.tsto includetodos.system-prompt/with-undefined-mcp-hub.snapand 8 other files for prompt text changes.This description was created by
for c1163b0. You can customize this summary. It will automatically update as commits are pushed.