feat(openrouter): cap horizon-alpha default output to 32k #6468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XS
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
| // Special-case: Slack request to cap OpenRouter horizon-alpha default output to 32k | ||
| // Only applies when routed via OpenRouter and the model id is exactly "openrouter/horizon-alpha" | ||
| if (format === "openrouter" && modelId === "openrouter/horizon-alpha") { | ||
| return 32_000 |
Contributor
Author
There was a problem hiding this comment.
Missing test coverage for this new special case logic. Could you add a test case to that verifies this function returns 32,000 when and ? The existing test suite has comprehensive coverage for other scenarios but lacks this specific combination.
| // Special-case: Slack request to cap OpenRouter horizon-alpha default output to 32k | ||
| // Only applies when routed via OpenRouter and the model id is exactly "openrouter/horizon-alpha" | ||
| if (format === "openrouter" && modelId === "openrouter/horizon-alpha") { | ||
| return 32_000 |
Contributor
Author
There was a problem hiding this comment.
Could we consider extracting this magic number to a named constant? Something like would improve maintainability if this value needs to be referenced elsewhere or changed in the future.
hannesrudolph
added
the
Issue/PR - Triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a targeted default so when routed via OpenRouter and modelId === "openrouter/horizon-alpha", getModelMaxOutputTokens() returns 32,000 (down from 128k). Applied in src/shared/api.ts to ensure consistent backend behavior without UI changes.
Important
Cap output to 32,000 tokens for
"openrouter/horizon-alpha"model when routed via OpenRouter ingetModelMaxOutputTokens().getModelMaxOutputTokens()inapi.ts, cap output to 32,000 tokens for modelId"openrouter/horizon-alpha"when routed via OpenRouter.This description was created by
for 718a75a. You can customize this summary. It will automatically update as commits are pushed.