Skip to content

Conversation

@roomote
Copy link
Contributor

@roomote roomote bot commented Jul 31, 2025

Summary: Fixes the inconsistent delete button visibility between the main chat screen and history screen by removing the size condition from the delete button rendering logic.

Changes Made:

  • TaskActions.tsx: Removed the size condition that was hiding the delete button for tasks with no size or size = 0
  • TaskActions.spec.tsx: Updated tests to reflect the new behavior where delete button is always visible when an item exists
  • Size display remains conditional and only shows when size > 0

Problem Solved: Previously, the delete button was only visible on task cards when item.size > 0, causing it to be hidden on the main screen for new/current tasks that might have size = 0 or undefined. This created an inconsistent user experience where users had to navigate to the history screen to delete tasks.

Testing:

  • All existing tests pass
  • Added new test cases for delete button visibility with size = 0 and undefined size
  • Verified that size display is still conditional (only shows when size > 0)

Fixes #6494


Important

Ensures delete button is always visible on task cards in TaskActions.tsx, regardless of task size, fixing UI inconsistency.

  • Behavior:
    • TaskActions.tsx: Delete button is now always visible for tasks, regardless of item.size.
    • Size display remains conditional, only showing when size > 0.
  • Testing:
    • TaskActions.spec.tsx: Updated tests to ensure delete button visibility for size = 0 and undefined.
    • Added test cases for delete button visibility with size = 0 and undefined.
  • Problem Solved:
    • Fixes inconsistent delete button visibility between main chat and history screens.

This description was created by Ellipsis for d2099e8. You can customize this summary. It will automatically update as commits are pushed.

- Remove size condition from delete button visibility in TaskActions component
- Delete button now appears for all tasks, not just those with size > 0
- Size display is still conditional and only shows when size > 0
- Update tests to reflect new behavior
- Fixes inconsistent UX between main screen and history screen

Fixes #6494
@roomote roomote bot requested review from cte, jr and mrubens as code owners July 31, 2025 16:40
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. bug Something isn't working labels Jul 31, 2025
roomote[bot]

This comment was marked as off-topic.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jul 31, 2025
@RooCodeInc RooCodeInc deleted a comment from roomote bot Jul 31, 2025
@RooCodeInc RooCodeInc deleted a comment from roomote bot Jul 31, 2025
@RooCodeInc RooCodeInc deleted a comment from roomote bot Jul 31, 2025
@RooCodeInc RooCodeInc deleted a comment from roomote bot Jul 31, 2025
@daniel-lxs daniel-lxs moved this from Triage to PR [Needs Prelim Review] in Roo Code Roadmap Jul 31, 2025
@hannesrudolph hannesrudolph added PR - Needs Preliminary Review and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Jul 31, 2025
@daniel-lxs
Copy link
Member

Closing PR as the issue cannot be reproduced. The delete button appears to be working correctly in the current implementation.

@daniel-lxs daniel-lxs closed this Aug 5, 2025
@github-project-automation github-project-automation bot moved this from PR [Needs Prelim Review] to Done in Roo Code Roadmap Aug 5, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Aug 5, 2025
@daniel-lxs daniel-lxs deleted the feature/fix-delete-button-visibility branch August 5, 2025 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working PR - Needs Preliminary Review size:M This PR changes 30-99 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Delete button is missing from main screen task cards

4 participants