Skip to content

fix: show delete button consistently on task cards regardless of size #6495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: show delete button consistently on task cards regardless of size #6495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions webview-ui/src/components/chat/TaskActions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export const TaskActions = ({ item, buttonsDisabled }: TaskActionsProps) => {
onClick={(e) => copyWithFeedback(item.task, e)}
/>
)}
{!!item?.size && item.size > 0 && (
{item && (
<>
<div className="flex items-center">
<IconButton
Expand All @@ -53,7 +53,11 @@ export const TaskActions = ({ item, buttonsDisabled }: TaskActionsProps) => {
}
}}
/>
<span className="ml-1 text-xs text-vscode-foreground opacity-85">{prettyBytes(item.size)}</span>
{!!item?.size && item.size > 0 && (
<span className="ml-1 text-xs text-vscode-foreground opacity-85">
{prettyBytes(item.size)}
</span>
)}
</div>
{deleteTaskId && (
<DeleteTaskDialog
Expand Down
25 changes: 23 additions & 2 deletions webview-ui/src/components/chat/__tests__/TaskActions.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,12 +361,33 @@ describe("TaskActions", () => {
expect(screen.getByText("1024 B")).toBeInTheDocument()
})

it("does not render delete button when item has no size", () => {
it("renders delete button even when item has no size", () => {
const itemWithoutSize = { ...mockItem, size: 0 }
render(<TaskActions item={itemWithoutSize} buttonsDisabled={false} />)

const deleteButton = screen.queryByLabelText("Delete Task (Shift + Click to skip confirmation)")
expect(deleteButton).not.toBeInTheDocument()
expect(deleteButton).toBeInTheDocument()
// Size should not be displayed when size is 0
expect(screen.queryByText("0 B")).not.toBeInTheDocument()
})

it("renders delete button when item has undefined size", () => {
const itemWithUndefinedSize = { ...mockItem, size: undefined }
render(<TaskActions item={itemWithUndefinedSize} buttonsDisabled={false} />)

const deleteButton = screen.queryByLabelText("Delete Task (Shift + Click to skip confirmation)")
expect(deleteButton).toBeInTheDocument()
// Size should not be displayed when size is undefined
expect(screen.queryByText("undefined B")).not.toBeInTheDocument()
})

it("renders delete button and size when item has valid size", () => {
render(<TaskActions item={mockItem} buttonsDisabled={false} />)

const deleteButton = screen.queryByLabelText("Delete Task (Shift + Click to skip confirmation)")
expect(deleteButton).toBeInTheDocument()
// Size should be displayed when size > 0
expect(screen.getByText("1024 B")).toBeInTheDocument()
})
})

Expand Down