-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Add slash commands tip to RooTips component #6527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@roomote reviewed its own code and found it lacking in 17 languages.
I've reviewed the changes and found some areas that need attention:
-
Incomplete translations: All non-English translations are using English placeholders for the slash commands feature. This means users in these locales will see English text mixed with their native language. Consider providing proper translations or at least documenting this as a known limitation that needs follow-up.
-
Documentation link verification: The documentation link references 'features/slash-commands' but I couldn't find this documentation page. Will this be added in a separate PR? Without the corresponding docs, users clicking this link might encounter a 404 error.
-
Tip ordering: The slash commands tip is placed as the third item. Is this the intended display order? You might want to consider if this placement aligns with the feature's importance or typical user workflow.
The implementation itself follows the existing patterns correctly, but the internationalization gap is the main concern.
|
@roomote reviewed its own code and found it lacking in 17 languages. I've reviewed the changes and found some areas that need attention: Incomplete translations: All non-English translations are using English placeholders for the slash commands feature. This means users in these locales will see English text mixed with their native language. Consider providing proper translations or at least documenting this as a known limitation that needs follow-up. Documentation link verification: The documentation link references 'features/slash-commands' but I couldn't find this documentation page. Will this be added in a separate PR? Without the corresponding docs, users clicking this link might encounter a 404 error. Tip ordering: The slash commands tip is placed as the third item. Is this the intended display order? You might want to consider if this placement aligns with the feature's importance or typical user workflow. The implementation itself follows the existing patterns correctly, but the internationalization gap is the main concern. |
|
Thanks for the thorough review @mrubens! I see the three issues youve identified:
Ill address these concerns now and update the PR accordingly. |
- Add TRANSLATION_TODO.md documenting missing translations for 11 languages - Update test to expect 4 links instead of 3 (3 tips + 1 docs link) - Document that slash commands documentation link is consistent with existing usage
|
Hi @mrubens, thanks for the review! I've addressed all your feedback:
All CI checks have passed. The changes are ready for review! |
daniel-lxs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Added information about slash commands feature to the RooTips component that displays on the welcome screen.
Changes Made:
Testing:
This addresses the Slack request to add information about slash commands to RooTips.
Important
Adds a slash commands tip to RooTips and updates translations with English placeholders.
RooTips.tsxwith an icon and documentation link.en/chat.jsonwith title and description for the slash commands tip.webview-ui.This description was created by
for e63b5a6. You can customize this summary. It will automatically update as commits are pushed.