-
Notifications
You must be signed in to change notification settings - Fork 2.6k
feat: reduce Gemini 2.5 Pro thinking tokens default from 1024 to 128 #6586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Changed minimum thinking tokens slider from 1024 to 128 in ThinkingBudget component - Changed default thinking tokens from 8192 to 128 in api constants - Adjusted slider step size from 1024 to 128 for finer control This change applies to all providers with thinking token settings defaulting to 1024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed my own code and found bugs I didn't know I wrote.
Critical Issues Found:
-
Backend/Frontend Inconsistency: The UI slider now allows a minimum of 128 tokens (in ), but the backend in (lines 102-105) still enforces a minimum of 1024 tokens. This means users can select values between 128-1023 in the UI, but the backend will silently override them to 1024.
-
Test Expectations Need Update: The test in (line 326) expects the minimum to be clamped to 1024, which conflicts with the new 128 minimum.
Suggestions:
-
PR Description Accuracy: The PR description mentions changing the default from 8192 to 128, but was already set to 8192 before this change. Could you clarify?
-
Model Compatibility: Consider whether 128 tokens is sufficient for all models that support reasoning budget. Different models might have different minimum requirements for effective reasoning.
|
@roomote-agent run pr-fixer |
|
I see the request to fix this PR. The unit tests are currently failing on both Ubuntu and Windows. Let me investigate and fix the issues. |
|
I have successfully fixed the failing unit tests for this PR. Here is what I did: Changes Made:
Test Results:
Note:The PR appears to have been closed, but I have pushed the test fixes to the branch Regarding the critical issues mentioned by the roomote bot:
|
This PR reduces the default and minimum thinking tokens for Gemini 2.5 Pro and other models with reasoning budget support.
Changes Made
Why This Change?
Per the Slack request, the user wants Gemini 2.5 Pro minimum max thinking to default at 128 instead of 1024. This change applies to all providers with thinking token settings that were defaulting to 1024.
Testing
Impact
This change will affect all models that support reasoning budget, providing users with:
Important
Reduce default and minimum thinking tokens for Gemini 2.5 Pro and similar models, enhancing control and efficiency.
api.ts.ThinkingBudget.tsx.ThinkingBudget.tsx.This description was created by
for 663ecc4. You can customize this summary. It will automatically update as commits are pushed.