Universal browser tool support #6598
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
| const contextWindow = | ||
| contextKey && typeof rawModel.model_info[contextKey] === "number" ? rawModel.model_info[contextKey] : undefined | ||
|
|
||
| // Check if this is a Qwen model that should support computer use |
Contributor
There was a problem hiding this comment.
I noticed this code checks if a model is a Qwen model but the variable is never used. Is this intentional? If not, should this check be integrated into the logic, or can it be removed?
| (rawModel as any).capabilities.some( | ||
| (cap: string) => | ||
| typeof cap === "string" && | ||
| ["computer_use", "computer-use", "browser", "tool_use", "tool-use"].includes(cap.toLowerCase()), |
Contributor
There was a problem hiding this comment.
Consider extracting these capability strings to a constant for better maintainability:
| trainedForToolUse: false, | ||
| maxContextLength: 4096, | ||
| contextLength: 4096, | ||
| capabilities: ["completion", "computer_use"], |
Contributor
There was a problem hiding this comment.
Good test coverage for the basic cases! Consider adding tests for the other capability variations that the implementation supports, such as "computer-use", "browser", "tool_use", and "tool-use". This would ensure all the supported formats are properly tested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related GitHub Issue
Closes: #
Roo Code Task Context (Optional)
Description
Test Procedure
Pre-Submission Checklist
Screenshots / Videos
Documentation Updates
Additional Notes
Get in Touch
Important
Add support for
supportsComputerUseflag in LMStudio and Ollama fetchers based on model capabilities or training status, with tests.parseLMStudioModelinlmstudio.tsandparseOllamaModelinollama.tsnow setsupportsComputerUseto true ifcapabilitiesincludescomputer_useor iftrainedForToolUseis true.lmstudio.test.tsandollama.test.tsto verifysupportsComputerUseflag behavior.getLMStudioModelsandgetOllamaModelsfor connection issues.getLMStudioModelsandgetOllamaModelsto handle default base URLs and connection errors more robustly.This description was created by
for 81113aa. You can customize this summary. It will automatically update as commits are pushed.