feat: add global system prompt override support #6815
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Users can now define global system prompts in ~/.roo/system-prompt-{mode}
- Local project prompts still take precedence over global ones
- Updated tests to cover the new functionality
- Fixes #6813
dosubot
bot
added
size:L
2 tasks
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
| let rawContent = await safeReadFile(localFilePath) | ||
|
|
||
| // If no local file exists, check for global system prompt | ||
| if (!rawContent) { |
Contributor
Author
There was a problem hiding this comment.
The implementation reads the local file even when it's empty before checking the global file. Could we optimize this by checking file existence first, then only reading if the file exists and is non-empty? This would avoid unnecessary file reads for empty files.
| } | ||
|
|
||
| /** | ||
| * Checks if there is a file-based system prompt override for the given mode |
Contributor
Author
There was a problem hiding this comment.
Consider adding a comment here explaining the precedence order (local > global) for future maintainers. Something like:
| @@ -1,16 +1,19 @@ | |||
| // Mocks must come first, before imports | |||
|
|
|||
| vi.mock("fs/promises") | |||
Contributor
Author
There was a problem hiding this comment.
The mock setup pattern here is clean, but could benefit from a comment explaining why mocks must come before imports for future test writers. This is a TypeScript/Vitest specific requirement that might not be obvious.
hannesrudolph
added
the
Issue/PR - Triage
Member
|
This is not planned |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for global system prompt overrides that can be defined in the user's home directory, eliminating the need to copy system prompt files to every repository.
Changes
~/.roo/system-prompt-{mode}.roo/system-prompt-{mode}) still take precedence over global onesgetGlobalSystemPromptFilePath()helper functionloadSystemPromptFile()to check both local and global locationshasFileBasedSystemPromptOverride()to check both locationsHow it works
.roo/system-prompt-{mode}~/.roo/system-prompt-{mode}Testing
Fixes
Fixes #6813
Checklist
Important
Adds support for global system prompt overrides, prioritizing local prompts, with updates to prompt loading logic and comprehensive tests.
~/.roo/system-prompt-{mode}..roo/system-prompt-{mode}) take precedence over global ones.loadSystemPromptFile()to check both local and global locations.hasFileBasedSystemPromptOverride()to check both locations.getGlobalSystemPromptFilePath()tocustom-system-prompt.ts.custom-system-prompt.spec.tsto verify global prompt usage and precedence logic.This description was created by
for 36af94e. You can customize this summary. It will automatically update as commits are pushed.