Skip to content

fix: add missing MCP error translation keys #6821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 7, 2025
Merged

fix: add missing MCP error translation keys #6821

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
30cbce4
fix: add missing MCP error translation keys
roomote Aug 7, 2025
35c255a
fix: remove fallback English strings from MCP error translations
roomote Aug 7, 2025
3ae64e7
fix: translate MCP error messages to all locales
roomote Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/i18n/locales/ca/mcp.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion src/i18n/locales/de/mcp.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion src/i18n/locales/en/mcp.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,10 @@
"invalid_settings_validation": "Invalid MCP settings format: {{errorMessages}}",
"create_json": "Failed to create or open .roo/mcp.json: {{error}}",
"failed_update_project": "Failed to update project MCP servers",
"invalidJsonArgument": "Roo tried to use {{toolName}} with an invalid JSON argument. Retrying..."
"invalidJsonArgument": "Roo tried to use {{toolName}} with an invalid JSON argument. Retrying...",
"refresh_after_disable": "Failed to refresh MCP connections after disabling",
"refresh_after_enable": "Failed to refresh MCP connections after enabling",
"disconnect_servers_partial": "Failed to disconnect {{count}} MCP server(s). Check the output for details."
Copy link
Contributor Author

@roomote roomote bot Aug 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor observation: The new keys use snake_case (refresh_after_disable, refresh_after_enable) while the existing invalidJsonArgument uses camelCase. Should we maintain consistent naming conventions across all keys? Not critical, but consistency helps with maintainability.

},
"info": {
"server_restarting": "Restarting {{serverName}} MCP server...",
Expand Down
5 changes: 4 additions & 1 deletion src/i18n/locales/es/mcp.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion src/i18n/locales/fr/mcp.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion src/i18n/locales/hi/mcp.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion src/i18n/locales/id/mcp.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion src/i18n/locales/it/mcp.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion src/i18n/locales/ja/mcp.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion src/i18n/locales/ko/mcp.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion src/i18n/locales/nl/mcp.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion src/i18n/locales/pl/mcp.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion src/i18n/locales/pt-BR/mcp.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion src/i18n/locales/ru/mcp.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion src/i18n/locales/tr/mcp.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion src/i18n/locales/vi/mcp.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion src/i18n/locales/zh-CN/mcp.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion src/i18n/locales/zh-TW/mcp.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading