Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/i18n/locales/ca/mcp.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion src/i18n/locales/de/mcp.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion src/i18n/locales/en/mcp.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,10 @@
"invalid_settings_validation": "Invalid MCP settings format: {{errorMessages}}",
"create_json": "Failed to create or open .roo/mcp.json: {{error}}",
"failed_update_project": "Failed to update project MCP servers",
"invalidJsonArgument": "Roo tried to use {{toolName}} with an invalid JSON argument. Retrying..."
"invalidJsonArgument": "Roo tried to use {{toolName}} with an invalid JSON argument. Retrying...",
"refresh_after_disable": "Failed to refresh MCP connections after disabling",
"refresh_after_enable": "Failed to refresh MCP connections after enabling",
"disconnect_servers_partial": "Failed to disconnect {{count}} MCP server(s). Check the output for details."
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor observation: The new keys use snake_case (refresh_after_disable, refresh_after_enable) while the existing invalidJsonArgument uses camelCase. Should we maintain consistent naming conventions across all keys? Not critical, but consistency helps with maintainability.

},
"info": {
"server_restarting": "Restarting {{serverName}} MCP server...",
Expand Down
5 changes: 4 additions & 1 deletion src/i18n/locales/es/mcp.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion src/i18n/locales/fr/mcp.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion src/i18n/locales/hi/mcp.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion src/i18n/locales/id/mcp.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion src/i18n/locales/it/mcp.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion src/i18n/locales/ja/mcp.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion src/i18n/locales/ko/mcp.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion src/i18n/locales/nl/mcp.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion src/i18n/locales/pl/mcp.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion src/i18n/locales/pt-BR/mcp.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion src/i18n/locales/ru/mcp.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion src/i18n/locales/tr/mcp.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion src/i18n/locales/vi/mcp.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion src/i18n/locales/zh-CN/mcp.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion src/i18n/locales/zh-TW/mcp.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 3 additions & 8 deletions src/services/mcp/McpHub.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1775,8 +1775,7 @@ export class McpHub {
t("mcp:errors.disconnect_servers_partial", {
count: disconnectionErrors.length,
errors: errorSummary,
}) ||
`Failed to disconnect ${disconnectionErrors.length} MCP server(s). Check the output for details.`,
}),
)
}

Expand All @@ -1785,19 +1784,15 @@ export class McpHub {
await this.refreshAllConnections()
} catch (error) {
console.error(`Failed to refresh MCP connections after disabling: ${error}`)
vscode.window.showErrorMessage(
t("mcp:errors.refresh_after_disable") || "Failed to refresh MCP connections after disabling",
)
vscode.window.showErrorMessage(t("mcp:errors.refresh_after_disable"))
}
} else {
// If MCP is being enabled, reconnect all servers
try {
await this.refreshAllConnections()
} catch (error) {
console.error(`Failed to refresh MCP connections after enabling: ${error}`)
vscode.window.showErrorMessage(
t("mcp:errors.refresh_after_enable") || "Failed to refresh MCP connections after enabling",
)
vscode.window.showErrorMessage(t("mcp:errors.refresh_after_enable"))
}
}
}
Expand Down
Loading