feat: hardcode temperature to 1 for GPT-5 models #6830
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR hardcodes the temperature to 1 for all GPT-5 model variants as requested by @mrubens in #6819.
Changes
getModelParamsfunction insrc/api/transform/model-params.tsto set temperature to 1 for models starting with "gpt-5"Testing
Context
This change was requested in PR #6819 to ensure consistent behavior for GPT-5 models by always using a temperature of 1, regardless of user settings or defaults.
Fixes: Follow-up to #6819
Important
Hardcodes temperature to 1 for GPT-5 models in
getModelParamsand adds tests to verify this behavior.getModelParamsinmodel-params.ts.model-params.spec.tsto verify temperature hardcoding for GPT-5 models.This description was created by
for d8092e3. You can customize this summary. It will automatically update as commits are pushed.