refactor: align ask_followup_question tool with current patterns #6879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add early return for partial blocks with incomplete required params - Make follow_up parameter required and validate it properly - Add validation for empty suggestions array - Improve error messages to be more specific - Update prompt description to clarify follow_up is required - Align error handling with other tools (consecutiveMistakeCount, recordToolError) - Minor text improvements in prompt description
dosubot
bot
added
size:L
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
| if (block.partial) { | ||
| // Early return if required parameter is not yet available | ||
| if (!question) { | ||
| return |
Contributor
Author
There was a problem hiding this comment.
Good alignment with other tools' patterns. The early return for partial blocks when the question parameter is incomplete follows the established pattern nicely.
| cline.consecutiveMistakeCount++ | ||
| cline.recordToolError("ask_followup_question") | ||
| await cline.say("error", `Failed to parse follow_up suggestions: ${error.message}`) | ||
| pushToolResult(formatResponse.toolError(`Invalid follow_up XML format: ${error.message}`)) |
Contributor
Author
There was a problem hiding this comment.
Is this error message specific enough? Consider adding guidance on the expected XML format, like: Invalid follow_up XML format: ${error.message}. Expected format: <suggest>text</suggest> or <suggest mode="mode-name">text</suggest>
| - follow_up: (required) A list of 2-4 suggested answers that logically follow from the question, ordered by priority or logical sequence. Each suggestion must: | ||
| 1. Be provided in its own <suggest> tag | ||
| 2. Be specific, actionable, and directly related to the completed task | ||
| 2. Be specific, actionable, and directly related to the question |
Contributor
Author
There was a problem hiding this comment.
Nice clarification changing from "related to the completed task" to "related to the question". This makes the documentation more accurate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aligns the
ask_followup_questiontool implementation with the patterns used by other tools in the codebase.Changes Made
Tool Implementation (
askFollowupQuestionTool.ts)follow_upparameter required and added proper validationconsecutiveMistakeCountandrecordToolErrorPrompt Description (
ask-followup-question.ts)follow_upis a required parameterTesting
core/tools/__tests__- all 161 tests passingContext
This change was requested via Slack to ensure the
ask_followup_questiontool follows the same patterns as other tools likewriteToFileTool,switchModeTool, andattemptCompletionToolfor consistency and maintainability.Important
Refactor
ask_followup_questiontool for parameter validation, error handling, and documentation alignment with other tools.askFollowupQuestionTool.ts):questionparameter.follow_upparameter required with validation.follow_up.consecutiveMistakeCountandrecordToolError.ask-followup-question.ts):follow_upas required.core/tools/__tests__- all 161 tests passing.This description was created by
for edf3ca5. You can customize this summary. It will automatically update as commits are pushed.