Skip to content

fix: handle null/undefined token values in ContextCondenseRow to prevent UI crash #6916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 21, 2025
Merged

fix: handle null/undefined token values in ContextCondenseRow to prevent UI crash #6916

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22a873d
fix: handle null/undefined token values in ContextCondenseRow to prev…
roomote Aug 11, 2025
cd98934
Delete webview-ui/src/components/chat/__tests__/ContextCondenseRow.sp…
daniel-lxs Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions webview-ui/src/components/chat/ContextCondenseRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,11 @@ export const ContextCondenseRow = ({ cost, prevContextTokens, newContextTokens,
const { t } = useTranslation()
const [isExpanded, setIsExpanded] = useState(false)

// Handle null/undefined token values to prevent crashes
const prevTokens = prevContextTokens ?? 0
Copy link
Contributor Author

@roomote roomote bot Aug 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice we're treating these values as optional here, but the Zod schema in packages/types/src/message.ts defines them as required fields. This creates a type safety issue.

Is this intentional? The schema has:

export const contextCondenseSchema = z.object({
  cost: z.number(),
  prevContextTokens: z.number(),
  newContextTokens: z.number(),
  summary: z.string(),
})

If these values can indeed be null/undefined in practice, we should update the schema to use .number().optional() to maintain type consistency across the codebase.

const newTokens = newContextTokens ?? 0
const displayCost = cost ?? 0
Copy link
Contributor Author

@roomote roomote bot Aug 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While defaulting to 0 prevents the crash, could this be misleading to users? When data is unavailable, showing "0 tokens" might imply no tokens were used, when actually the data is missing.

Would it be clearer to display "--" or "N/A" when values are null/undefined?

Suggested change
const displayCost = cost ?? 0
const prevTokens = prevContextTokens ?? 0
const newTokens = newContextTokens ?? 0
const displayCost = cost ?? 0
const hasValidData = prevContextTokens != null && newContextTokens != null


return (
<div className="mb-2">
<div
Expand All @@ -33,9 +38,11 @@ export const ContextCondenseRow = ({ cost, prevContextTokens, newContextTokens,
<span className="codicon codicon-compress text-blue-400" />
<span className="font-bold text-vscode-foreground">{t("chat:contextCondense.title")}</span>
<span className="text-vscode-descriptionForeground text-sm">
{prevContextTokens.toLocaleString()} → {newContextTokens.toLocaleString()} {t("tokens")}
{prevTokens.toLocaleString()} → {newTokens.toLocaleString()} {t("tokens")}
</span>
<VSCodeBadge className={cost > 0 ? "opacity-100" : "opacity-0"}>${cost.toFixed(2)}</VSCodeBadge>
<VSCodeBadge className={displayCost > 0 ? "opacity-100" : "opacity-0"}>
${displayCost.toFixed(2)}
</VSCodeBadge>
</div>
<span className={`codicon codicon-chevron-${isExpanded ? "up" : "down"}`}></span>
</div>
Expand Down
Loading