Fix allowedMaxRequests and allowedMaxCost values not showing in the settings UI #6925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XS
hannesrudolph
added
the
Issue/PR - Triage
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Thank you for your contribution! This is a clean and focused fix that correctly addresses the display issue.
The change properly converts values to using the nullish coalescing operator, which aligns with how the FormattedTextField component expects to handle empty values. The fix is minimal, targeted, and follows the existing patterns in the codebase.
LGTM! 🎯
| followupAutoApproveTimeoutMs={followupAutoApproveTimeoutMs} | ||
| allowedCommands={allowedCommands} | ||
| allowedMaxRequests={allowedMaxRequests ?? undefined} | ||
| allowedMaxCost={allowedMaxCost ?? undefined} |
Contributor
There was a problem hiding this comment.
Good fix! Using here ensures that values are properly converted to , which the FormattedTextField component expects for displaying empty fields. This is consistent with how the component's formatters are designed to work.
chrarnoldus
added a commit
to Kilo-Org/kilocode
that referenced
this pull request
Aug 11, 2025
…ettings UI Fixes #1880 The kangaroo likes it: RooCodeInc/Roo-Code#6925
hannesrudolph
added
PR - Needs Preliminary Review
and removed
Issue/PR - Triage
daniel-lxs
moved this from PR [Needs Prelim Review]
to PR [Needs Review]
in Roo Code Roadmap
mrubens
approved these changes
Aug 14, 2025
Collaborator
|
Thank you! |
github-project-automation
bot
moved this from PR [Needs Review]
to Done
in Roo Code Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kilo Code issue: Kilo-Org/kilocode#1880
Description
Relevant properties were not set on AutoApproveSettings, causes the value to be saved but not shown.
Test Procedure
Open settings, edit allowedMaxRequests and allowedMaxCost and verify the values stay on-screen when the inputs lose focus.
Get in Touch
Christiaan in shared Slack
Important
Fixes display issue for
allowedMaxRequestsandallowedMaxCostin settings UI by ensuring proper value assignment inSettingsView.tsx.allowedMaxRequestsandallowedMaxCostvalues were not displayed in the settings UI.undefinedif not provided, preventing display issues.SettingsViewinSettingsView.tsxto includeallowedMaxRequestsandallowedMaxCostwith fallback toundefined.This description was created by
for 9340758. You can customize this summary. It will automatically update as commits are pushed.