Skip to content

Conversation

@PeterDaveHello
Copy link
Contributor

@PeterDaveHello PeterDaveHello commented Aug 11, 2025

Description

Remove deprecated GPT-4.5 Preview model. It was removed from the API about a month ago.

Reference:

https://platform.openai.com/docs/models/gpt-4.5-preview

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Testing: New and/or updated tests have been added to cover my changes (if applicable).
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Documentation Updates

Get in Touch

Discord username: PeterDaveHello


Important

Remove deprecated gpt-4.5-preview model from openai.ts.

  • Removal:
    • Removed gpt-4.5-preview model from openAiNativeModels in openai.ts. This model was deprecated and removed from the API.

This description was created by Ellipsis for 28a1e21. You can customize this summary. It will automatically update as commits are pushed.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 11, 2025
Copy link
Contributor

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! This is a clean and necessary removal of the deprecated GPT-4.5 Preview model. The change looks good and I've verified there are no references to this model elsewhere in the codebase.

A couple of suggestions for future improvements:

  1. Consider linking PRs to GitHub issues even for simple deprecation removals - this helps with documentation and tracking.
  2. It might be worth adding tests for the openAiNativeModels configuration to ensure model configs remain valid after changes.

inputPrice: 1.1,
outputPrice: 4.4,
cacheReadsPrice: 0.55,
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good removal of the deprecated model. The deletion is clean and doesn't affect the surrounding model configurations.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Aug 12, 2025
@daniel-lxs daniel-lxs moved this from Triage to PR [Needs Review] in Roo Code Roadmap Aug 13, 2025
Copy link
Member

@daniel-lxs daniel-lxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @PeterDaveHello !

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 13, 2025
@mrubens mrubens merged commit 4c01866 into RooCodeInc:main Aug 13, 2025
22 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Aug 13, 2025
@github-project-automation github-project-automation bot moved this from PR [Needs Review] to Done in Roo Code Roadmap Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants