-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Remove deprecated GPT-4.5 Preview model #6948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated GPT-4.5 Preview model #6948
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! This is a clean and necessary removal of the deprecated GPT-4.5 Preview model. The change looks good and I've verified there are no references to this model elsewhere in the codebase.
A couple of suggestions for future improvements:
- Consider linking PRs to GitHub issues even for simple deprecation removals - this helps with documentation and tracking.
- It might be worth adding tests for the openAiNativeModels configuration to ensure model configs remain valid after changes.
| inputPrice: 1.1, | ||
| outputPrice: 4.4, | ||
| cacheReadsPrice: 0.55, | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good removal of the deprecated model. The deletion is clean and doesn't affect the surrounding model configurations.
daniel-lxs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @PeterDaveHello !
Description
Remove deprecated GPT-4.5 Preview model. It was removed from the API about a month ago.
Reference:
https://platform.openai.com/docs/models/gpt-4.5-preview
Pre-Submission Checklist
Documentation Updates
Get in Touch
Discord username: PeterDaveHello
Important
Remove deprecated
gpt-4.5-previewmodel fromopenai.ts.gpt-4.5-previewmodel fromopenAiNativeModelsinopenai.ts. This model was deprecated and removed from the API.This description was created by
for 28a1e21. You can customize this summary. It will automatically update as commits are pushed.