fix: disable PostHog service worker to prevent VSCode webview errors #6951
Conversation
… VSCode webview - Added configuration options to PostHog initialization to disable service worker features - Disabled session recording, toolbar metrics, and other features that may attempt service worker registration - Updated tests to reflect the new PostHog configuration - Fixes #6950: Error loading webview due to service worker registration failure
dosubot
bot
added
size:S
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
| autocapture: false, | ||
| // Disable service worker to prevent registration errors in VSCode webview | ||
| disable_session_recording: true, | ||
| disable_persistence: false, |
There was a problem hiding this comment.
Is intentional? We're trying to avoid service worker issues, but keeping persistence enabled might still cause problems in VSCode webviews since localStorage can be restricted. Should this be to fully prevent any persistence-related issues?
| opt_out_capturing_by_default: false, | ||
| // Use XHR instead of fetch to avoid service worker issues | ||
| xhr_headers: { | ||
| "Content-Type": "application/json", |
There was a problem hiding this comment.
The configuration seems redundant - PostHog should handle Content-Type automatically. Is this actually needed to prevent service worker registration, or could we remove it to simplify the config?
| "Content-Type": "application/json", | ||
| }, | ||
| // Disable features that might try to use service workers | ||
| bootstrap: {}, |
There was a problem hiding this comment.
Consider grouping these options more clearly or adding more specific comments. For example, isn't obviously related to preventing service worker registration. Maybe separate the options into groups like 'service worker prevention', 'feature disabling', etc?
| capture_pageview: false, | ||
| capture_pageleave: false, | ||
| autocapture: false, | ||
| disable_session_recording: true, |
There was a problem hiding this comment.
The test only verifies some of the new configuration options. Should we add assertions for all the new config properties (, , , , , etc.) to ensure they're properly set?
| capture_pageview: false, | ||
| capture_pageleave: false, | ||
| autocapture: false, | ||
| disable_session_recording: true, |
There was a problem hiding this comment.
Same issue here - missing test assertions for several of the new configuration options. Consider adding comprehensive checks for all PostHog init parameters to prevent regression.
hannesrudolph
added
the
Issue/PR - Triage
|
Closing, the issue is not properly scoped |
Summary
This PR fixes issue #6950 where users were experiencing "Error loading webview: Error: Could not register service worker" when trying to start Roo Code in VSCode.
Problem
The PostHog analytics library was attempting to register a service worker, which is not supported in VSCode webview contexts. This caused the webview to fail to load with an InvalidStateError.
Solution
Testing
Related Issue
Fixes #6950
Type of Change
Important
Disables PostHog service worker features in
TelemetryClient.tsto prevent VSCode webview errors and updates tests accordingly.TelemetryClient.tsto prevent VSCode webview errors.TelemetryClient.ts.TelemetryClient.spec.tsand__tests__/TelemetryClient.spec.tsto verify new PostHog configuration options.TelemetryClient.ts.This description was created by
for 3305c52. You can customize this summary. It will automatically update as commits are pushed.